[dead-code] Add RemoveParentDelegatingConstructorRector

Author: TomasVotruba

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/Fixture/some_class.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Fixture;
+
+use PhpParser\Node\Scalar\String_;
+
+final class SomeClass extends String_
+{
+    public function __construct($value, $attributes)
+    {
+        parent::__construct($value, $attributes);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Fixture;
+
+use PhpParser\Node\Scalar\String_;
+
+final class SomeClass extends String_
+{
+}
+
+?>

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/RemoveParentDelegatingConstructorRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveParentDelegatingConstructorRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector;
+
+return RectorConfig::configure()
+    ->withRules([RemoveParentDelegatingConstructorRector::class]);

rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector.php

@@ -0,0 +1,136 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\DeadCode\Rector\ClassMethod;
+
+use PhpParser\Node;
+use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\NodeVisitor;
+use PHPStan\Reflection\ClassReflection;
+use Rector\Enum\ObjectReference;
+use Rector\NodeAnalyzer\ArgsAnalyzer;
+use Rector\NodeAnalyzer\ExprAnalyzer;
+use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\PHPStan\ScopeFetcher;
+use Rector\Rector\AbstractRector;
+use Rector\Reflection\ReflectionResolver;
+use Rector\ValueObject\MethodName;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * @see \Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\RemoveParentDelegatingConstructorRectorTest
+ */
+final class RemoveParentDelegatingConstructorRector extends AbstractRector
+{
+    public function __construct(
+        private readonly ReflectionResolver $reflectionResolver,
+        private readonly ArgsAnalyzer $argsAnalyzer,
+        private readonly ValueResolver $valueResolver,
+        private readonly ExprAnalyzer $exprAnalyzer
+    ) {
+    }
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Remove constructor that only delegates call to parent class with same values',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+class Node
+{
+    public function __construct(array $attributes)
+    {
+    }
+}
+
+class SomeParent extends Node
+{
+    public function __construct(array $attributes)
+    {
+        parent::__construct($attributes);
+    }
+}
+CODE_SAMPLE
+                    ,
+                    <<<'CODE_SAMPLE'
+class Node
+{
+    public function __construct(array $attributes)
+    {
+    }
+}
+
+class SomeParent extends Node
+{
+}
+CODE_SAMPLE
+                ),
+            ]
+        );
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [ClassMethod::class];
+    }
+
+    /**
+     * @param ClassMethod $node
+     */
+    public function refactor(Node $node): ?int
+    {
+        if (! $this->isName($node, MethodName::CONSTRUCT)) {
+            return null;
+        }
+
+        if (count($node->stmts) !== 1) {
+            return null;
+        }
+
+        $scope = ScopeFetcher::fetch($node);
+        $classReflection = $scope->getClassReflection();
+        if (! $classReflection->getParentClass() instanceof ClassReflection) {
+            return null;
+        }
+
+        $parentClassReflection = $classReflection->getParentClass();
+        if (! $parentClassReflection->hasConstructor()) {
+            return null;
+        }
+
+        // $parentClassReflectionConstructor = $parentClassReflection->getConstructor();
+
+        $soleStmt = $node->stmts[0];
+        if (! $soleStmt instanceof Node\Stmt\Expression) {
+            return null;
+        }
+
+        if (! $soleStmt->expr instanceof Node\Expr\StaticCall) {
+            return null;
+        }
+
+        $staticCall = $soleStmt->expr;
+        if (! $this->isName($staticCall->class, ObjectReference::PARENT)) {
+            return null;
+        }
+
+        if (! $this->isName($staticCall->name, MethodName::CONSTRUCT)) {
+            return null;
+        }
+
+        $constructorParams = $node->getParams();
+        $parentCallArgs = $staticCall->getArgs();
+
+        if (count($constructorParams) !== count($parentCallArgs)) {
+            return null;
+        }
+
+        return NodeVisitor::REMOVE_NODE;
+    }
+}

src/Reporting/DeprecatedRulesReporter.php

@@ -4,13 +4,13 @@
 
 namespace Rector\Reporting;
 
-use Rector\PhpParserNode\FileNode;
 use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
 use Rector\Configuration\Option;
 use Rector\Configuration\Parameter\SimpleParameterProvider;
 use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
 use Rector\Contract\Rector\RectorInterface;
 use Rector\PhpParser\Enum\NodeGroup;
+use Rector\PhpParserNode\FileNode;
 use ReflectionMethod;
 use Symfony\Component\Console\Style\SymfonyStyle;