[Privatization] Skip FinalizeTestCaseClassRector for classes without Test suffix

Author: TomasVotruba

rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/skip_without_test_suffix.php.inc

@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class SomeReusableHelper extends TestCase
+{
+}

rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/some_class.php.inc

@@ -4,7 +4,7 @@ namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\F
 
 use PHPUnit\Framework\TestCase;
 
-class SomeClass extends TestCase
+class SomeClassTest extends TestCase
 {
 }
 
@@ -16,7 +16,7 @@ namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\F
 
 use PHPUnit\Framework\TestCase;
 
-final class SomeClass extends TestCase
+final class SomeClassTest extends TestCase
 {
 }
 

rules-tests/Privatization/Rector/Class_/FinalizeTestCaseClassRector/Fixture/with_attribute_new_line.php.inc

@@ -5,7 +5,7 @@ namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\F
 use PHPUnit\Framework\TestCase;
 
 #[CoversClass(Advisor::class)]
-class WithAttributeNewLine extends TestCase
+class WithAttributeNewLineTest extends TestCase
 {
 }
 
@@ -18,7 +18,7 @@ namespace Rector\Tests\Privatization\Rector\Class_\FinalizeTestCaseClassRector\F
 use PHPUnit\Framework\TestCase;
 
 #[CoversClass(Advisor::class)]
-final class WithAttributeNewLine extends TestCase
+final class WithAttributeNewLineTest extends TestCase
 {
 }
 

rules/Privatization/Rector/Class_/FinalizeTestCaseClassRector.php

@@ -74,6 +74,11 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        // skip classes without "Test" suffix, as those are meant to be extended
+        if (! str_ends_with($className, 'Test')) {
+            return null;
+        }
+
         if (! $this->reflectionProvider->hasClass($className)) {
             return null;
         }