register rule

Author: TomasVotruba

rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_method_calls_to_keep_readability.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\ClassMethod\BinaryOpStandaloneAssignsToDirectRector\Fixture;
+
+final class SkipMethodCallsToKeepReadability
+{
+    public function run()
+    {
+        $first = $this->createLongValue(100);
+        $second = $this->createLongValue(200);
+
+        return $first <=> $second;
+    }
+
+    private function createLongValue($value)
+    {
+        return $value . ' is long';
+    }
+}

rules/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector.php

@@ -8,6 +8,7 @@
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\BinaryOp;
 use PhpParser\Node\Expr\Closure;
+use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -131,6 +132,11 @@ private function matchToVariableAssignExpr(Stmt $stmt): ?VariableAndExprAssign
             return null;
         }
 
+        // skip complex cases
+        if ($assign->expr instanceof MethodCall) {
+            return null;
+        }
+
         return new VariableAndExprAssign($assign->var, $assign->expr);
     }
 }

src/Config/Level/CodingStyleLevel.php

@@ -8,6 +8,7 @@
 use Rector\CodingStyle\Rector\Catch_\CatchExceptionNameMatchingTypeRector;
 use Rector\CodingStyle\Rector\ClassConst\RemoveFinalFromConstRector;
 use Rector\CodingStyle\Rector\ClassConst\SplitGroupedClassConstantsRector;
+use Rector\CodingStyle\Rector\ClassMethod\BinaryOpStandaloneAssignsToDirectRector;
 use Rector\CodingStyle\Rector\ClassMethod\FuncGetArgsToVariadicParamRector;
 use Rector\CodingStyle\Rector\ClassMethod\MakeInheritedMethodVisibilitySameAsParentRector;
 use Rector\CodingStyle\Rector\ClassMethod\NewlineBeforeNewAssignSetRector;
@@ -77,6 +78,7 @@ final class CodingStyleLevel
         SplitGroupedClassConstantsRector::class,
         ExplicitPublicClassMethodRector::class,
         RemoveUselessAliasInUseStatementRector::class,
+        BinaryOpStandaloneAssignsToDirectRector::class,
     ];
 
     /**