[CodeQuality] Skip next inside array_filter() on SimplifyEmptyArrayCheckRector (#7154)

Author: samsonasik

rules-tests/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector/Fixture/fixture.php.inc

@@ -13,11 +13,6 @@ final class Fixture
     {
         return empty($values) && is_array($values);
     }
-
-    public function functionCallInsideEmpty($values): bool
-    {
-        return is_array($values) && empty(array_filter($values));
-    }
 }
 
 ?>
@@ -37,11 +32,6 @@ final class Fixture
     {
         return $values === [];
     }
-
-    public function functionCallInsideEmpty($values): bool
-    {
-        return array_filter($values) === [];
-    }
 }
 
 ?>

rules-tests/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector/Fixture/skip_right_inside_array_filter.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector\Fixture;
+
+final class SkipRightInsideArrayFilter
+{
+    public function example(mixed $value): bool {
+        if (is_array($value) && empty(array_filter($value))) {
+            return true;
+        }
+
+        return false;
+    }
+}

rules/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector.php

@@ -10,6 +10,7 @@
 use PhpParser\Node\Expr\BinaryOp\Identical;
 use PhpParser\Node\Expr\Empty_;
 use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Expr\Variable;
 use Rector\NodeManipulator\BinaryOpManipulator;
 use Rector\Php71\ValueObject\TwoNodeMatch;
 use Rector\Rector\AbstractRector;
@@ -95,27 +96,19 @@ function (Node $node): bool {
                     return false;
                 }
 
-                return isset($node->getArgs()[0]);
+                if (isset($node->getArgs()[0])) {
+                    return $node->getArgs()[0]->value instanceof Variable;
+                }
+
+                return false;
             },
             // empty(...)
             function (Node $node): bool {
                 if (! $node instanceof Empty_) {
                     return false;
                 }
 
-                if ($node->expr instanceof FuncCall) {
-                    if ($node->expr->isFirstClassCallable()) {
-                        return false;
-                    }
-
-                    if (! $this->isName($node->expr, 'array_filter')) {
-                        return false;
-                    }
-
-                    return isset($node->expr->getArgs()[0]);
-                }
-
-                return true;
+                return $node->expr instanceof Variable;
             }
         );
     }