Skip to content

Commit d253ff3

Browse files
committed
fix
1 parent bd6a585 commit d253ff3

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

rules/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use PhpParser\Node\Stmt\If_;
1414
use PhpParser\Node\Stmt\Return_;
1515
use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
16+
use Rector\DeadCode\SideEffect\SideEffectNodeDetector;
1617
use Rector\Rector\AbstractRector;
1718
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
1819
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -22,6 +23,11 @@
2223
*/
2324
final class RemoveConditionExactReturnRector extends AbstractRector
2425
{
26+
public function __construct(
27+
private readonly SideEffectNodeDetector $sideEffectNodeDetector
28+
) {
29+
}
30+
2531
public function getRuleDefinition(): RuleDefinition
2632
{
2733
return new RuleDefinition(
@@ -94,12 +100,8 @@ public function refactor(Node $node): ?Node
94100
}
95101

96102
$identicalOrEqual = $stmt->cond;
97-
// skip obvious complexity
98-
if ($identicalOrEqual->right instanceof MethodCall) {
99-
continue;
100-
}
101103

102-
if ($identicalOrEqual->right instanceof StaticCall) {
104+
if ($this->sideEffectNodeDetector->detect($identicalOrEqual->right)) {
103105
continue;
104106
}
105107

0 commit comments

Comments
 (0)