skip get/set magic

Author: TomasVotruba

rules-tests/Php84/Rector/Class_/PropertyHookRector/Fixture/skip_get_set_magic.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\Class_\PropertyHookRector\Fixture;
+
+final class SkipGetSetMagic
+{
+    private string $name;
+
+    public function getName(): string
+    {
+        return $this->name;
+    }
+
+    public function setName(string $name): void
+    {
+        $this->name = ucfirst($name);
+    }
+
+    public function __get($name)
+    {
+    }
+
+    public function __set($name, $value)
+    {
+    }
+}

rules/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector.php

@@ -74,6 +74,11 @@ public function refactor(Node $node): null|CallLike
         return $callLike;
     }
 
+    public function provideMinPhpVersion(): int
+    {
+        return PhpVersionFeature::FIRST_CLASS_CALLABLE_SYNTAX;
+    }
+
     private function shouldSkip(
         ArrowFunction|Closure $node,
         FuncCall|MethodCall|StaticCall $callLike,
@@ -240,9 +245,4 @@ private function isChainedCall(FuncCall|MethodCall|StaticCall $callLike): bool
 
         return $callLike->var instanceof CallLike;
     }
-
-    public function provideMinPhpVersion(): int
-    {
-        return PhpVersionFeature::FIRST_CLASS_CALLABLE_SYNTAX;
-    }
 }

rules/Php74/Rector/Double/RealToFloatTypeCastRector.php

@@ -4,12 +4,12 @@
 
 namespace Rector\Php74\Rector\Double;
 
-use Rector\Renaming\Rector\Cast\RenameCastRector;
 use PhpParser\Node;
 use PhpParser\Node\Expr\Cast\Double;
 use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
 use Rector\Exception\ShouldNotHappenException;
 use Rector\Rector\AbstractRector;
+use Rector\Renaming\Rector\Cast\RenameCastRector;
 use Rector\ValueObject\PhpVersionFeature;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;

rules/Php84/Rector/Class_/PropertyHookRector.php

@@ -13,6 +13,7 @@
 use Rector\Php84\NodeFactory\PropertyHookFactory;
 use Rector\Php84\NodeFinder\SetterAndGetterFinder;
 use Rector\Rector\AbstractRector;
+use Rector\ValueObject\MethodName;
 use Rector\ValueObject\PhpVersionFeature;
 use Rector\VendorLocker\ParentClassMethodTypeOverrideGuard;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -82,6 +83,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($this->hasMagicGetSetMethod($node)) {
+            return null;
+        }
+
         // nothing to hook to
         if ($node->getProperties() === []) {
             return null;
@@ -149,4 +154,15 @@ public function provideMinPhpVersion(): int
     {
         return PhpVersionFeature::PROPERTY_HOOKS;
     }
+
+    private function hasMagicGetSetMethod(Class_ $class): bool
+    {
+        $magicGetMethod = $class->getMethod(MethodName::__GET);
+        if ($magicGetMethod instanceof ClassMethod) {
+            return true;
+        }
+
+        $magicSetMethod = $class->getMethod(MethodName::__SET);
+        return $magicSetMethod instanceof ClassMethod;
+    }
 }