[DeadCode] Skip ClassLikeNameClassNameImportSkipVoter for RecastingRemovalRector (#7448)

Author: samsonasik

rector.php

@@ -4,6 +4,7 @@
 
 use Rector\CodingStyle\Rector\String_\UseClassKeywordForClassNameResolutionRector;
 use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\Cast\RecastingRemovalRector;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 
@@ -52,4 +53,9 @@
             __DIR__ . '/src/Configuration/RectorConfigBuilder.php',
             __DIR__ . '/src/Console/Notifier.php',
         ],
+
+        // on php 7.x, substr() result can return false, so force (string) is needed
+        RecastingRemovalRector::class => [
+            __DIR__ . '/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php',
+        ],
     ]);

rules-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/skip_substr.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Fixture;
+
+class WithSubstr
+{
+    public function run(): string
+    {
+        $className = 'Exception';
+        return (string) substr($className, 0, -strlen($className) - 1);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Fixture;
+
+class WithSubstr
+{
+    public function run(): string
+    {
+        $className = 'Exception';
+        return substr($className, 0, -strlen($className) - 1);
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/with_substr.php.inc

@@ -13,14 +13,12 @@
 use PhpParser\Node\Expr\Cast\Int_;
 use PhpParser\Node\Expr\Cast\Object_;
 use PhpParser\Node\Expr\Cast\String_;
-use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use PHPStan\Reflection\Php\PhpPropertyReflection;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\Constant\ConstantArrayType;
-use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\FloatType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
@@ -105,13 +103,6 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        // substr can return false on php 7.x
-        if ($node->expr instanceof FuncCall
-            && $this->isName($node->expr, 'substr')
-            && ! $node->expr->isFirstClassCallable()) {
-            $nodeType = new UnionType([new StringType(), new ConstantBooleanType(false)]);
-        }
-
         if ($nodeType instanceof ConstantArrayType && $nodeClass === Array_::class) {
             if ($this->shouldSkip($node->expr)) {
                 return null;