skip @ return this on RemoveReturnTagIncompatibleWithNativeTypeRector on Traits (#8185)

* skip return $this removal on trait on RemoveReturnTagIncompatibleWithNativeTypeRector

* skip return $this removal on trait on RemoveReturnTagIncompatibleWithNativeTypeRector

* fix cs

* fix phpstan

Author: samsonasik

rules-tests/DeadCode/Rector/ClassMethod/RemoveReturnTagIncompatibleWithNativeTypeRector/Fixture/skip_this_return_in_trait.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveReturnTagIncompatibleWithNativeTypeRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\ClassMethod\RemoveReturnTagIncompatibleWithNativeTypeRector\Source\RouteInterface;
+
+trait SkipThisReturnInTrait
+{
+    /**
+     * @return $this
+     */
+    public function withVerbs(): RouteInterface
+    {
+        return clone $this;
+    }
+}

rules-tests/DeadCode/Rector/ClassMethod/RemoveReturnTagIncompatibleWithNativeTypeRector/Source/RouteInterface.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveReturnTagIncompatibleWithNativeTypeRector\Source;
+
+interface RouteInterface
+{
+}

rules/DeadCode/Rector/ClassMethod/RemoveReturnTagIncompatibleWithNativeTypeRector.php

@@ -12,10 +12,13 @@
 use PHPStan\PhpDocParser\Ast\PhpDoc\ReturnTagValueNode;
 use PHPStan\PhpDocParser\Ast\Type\GenericTypeNode;
 use PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode;
+use PHPStan\PhpDocParser\Ast\Type\ThisTypeNode;
+use PHPStan\Reflection\ClassReflection;
+use PHPStan\Type\ObjectType;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
-use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
 use Rector\StaticTypeMapper\StaticTypeMapper;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -109,11 +112,20 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if ($this->isClassTypeAlias($node, $returnTagValueNode)) {
+        $scope = ScopeFetcher::fetch($node);
+        if ($this->isClassTypeAlias($scope, $returnTagValueNode)) {
             return null;
         }
 
         $nativeReturnType = $this->staticTypeMapper->mapPhpParserNodePHPStanType($node->returnType);
+        $classReflection = $scope->getClassReflection();
+        if ($classReflection instanceof ClassReflection && $classReflection->isTrait()
+            && $returnTagValueNode->type instanceof ThisTypeNode
+            && $nativeReturnType instanceof ObjectType
+        ) {
+            return null;
+        }
+
         if ($this->isReturnTemplate($phpDocInfo, $returnTagValueNode)) {
             return null;
         }
@@ -134,10 +146,9 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
-    private function isClassTypeAlias(Node $node, ReturnTagValueNode $returnTagValueNode): bool
+    private function isClassTypeAlias(Scope $scope, ReturnTagValueNode $returnTagValueNode): bool
     {
-        $scope = $node->getAttribute(AttributeKey::SCOPE);
-        if (! $scope instanceof Scope || ! $scope->isInClass()) {
+        if (! $scope->isInClass()) {
             return false;
         }