Print warning instead of throwing an error

Author: carlos-granados

rules/Arguments/ArgumentDefaultValueReplacer.php

@@ -108,15 +108,15 @@ private function processArgs(
         }
 
         $argValue = $this->valueResolver->getValue($particularArg->value);
-
         if (is_scalar(
             $replaceArgumentDefaultValue->getValueBefore()
         ) && $argValue === $replaceArgumentDefaultValue->getValueBefore()) {
             $expr->args[$position] = $this->normalizeValueToArgument($replaceArgumentDefaultValue->getValueAfter());
             return $expr;
-        } elseif (is_array($replaceArgumentDefaultValue->getValueBefore())) {
-            $newArgs = $this->processArrayReplacement($expr->getArgs(), $replaceArgumentDefaultValue);
+        }
 
+        if (is_array($replaceArgumentDefaultValue->getValueBefore())) {
+            $newArgs = $this->processArrayReplacement($expr->getArgs(), $replaceArgumentDefaultValue);
             if (is_array($newArgs)) {
                 $expr->args = $newArgs;
                 return $expr;

src/Exception/Configuration/RectorRuleShouldNotBeAppliedException.php

@@ -18,7 +18,6 @@
 use Rector\Contract\DependencyInjection\ResetableInterface;
 use Rector\Contract\Rector\RectorInterface;
 use Rector\DependencyInjection\Laravel\ContainerMemento;
-use Rector\Exception\Configuration\RectorRuleShouldNotBeAppliedException;
 use Rector\Exception\ShouldNotHappenException;
 use Rector\NodeTypeResolver\Reflection\BetterReflection\SourceLocatorProvider\DynamicSourceLocatorProvider;
 use Rector\PhpParser\NodeTraverser\RectorNodeTraverser;
@@ -166,6 +165,23 @@ protected function doTestFile(string $fixtureFilePath): void
         );
     }
 
+    protected function doTestFileExpectingWarningAboutRuleApplied(
+        string $fixtureFilePath,
+        string $expectedRuleApplied
+    ): void {
+        ob_start();
+        $this->doTestFile($fixtureFilePath);
+        $content = ob_get_clean();
+        $fixtureName = basename($fixtureFilePath);
+        $testClass = static::class;
+        $this->assertSame(
+            PHP_EOL . "WARNING: On fixture file \"" . $fixtureName . '" for test "' . $testClass . "\"" . PHP_EOL .
+            "File not changed but some Rector rules applied:" . PHP_EOL .
+            ' * ' . $expectedRuleApplied . PHP_EOL,
+            $content
+        );
+    }
+
     private function forgetRectorsRules(): void
     {
         $rectorConfig = self::getContainer();
@@ -208,9 +224,8 @@ private function doTestFileMatchesExpectedContent(
         $changedContents = $rectorTestResult->getChangedContents();
 
         $fixtureFilename = basename($fixtureFilePath);
-        $fixtureNameMessage = sprintf('Failed on fixture file "%s"', $fixtureFilename);
+        $failureMessage = sprintf('Failed on fixture file "%s"', $fixtureFilename);
 
-        $failureMessage = $fixtureNameMessage;
         $numAppliedRectorClasses = count($rectorTestResult->getAppliedRectorClasses());
         // give more context about used rules in case of set testing
         $appliedRulesList = '';
@@ -234,9 +249,13 @@ private function doTestFileMatchesExpectedContent(
         }
 
         if ($inputFileContents === $expectedFileContents && $numAppliedRectorClasses > 0) {
-            $failureMessage = $fixtureNameMessage . PHP_EOL . PHP_EOL
+            $failureMessage = PHP_EOL . sprintf(
+                'WARNING: On fixture file "%s" for test "%s"',
+                $fixtureFilename,
+                static::class
+            ) . PHP_EOL
                 . 'File not changed but some Rector rules applied:' . PHP_EOL . $appliedRulesList;
-            throw new RectorRuleShouldNotBeAppliedException($failureMessage);
+            echo $failureMessage;
         }
     }
 

src/Testing/PHPUnit/AbstractRectorTestCase.php

@@ -6,16 +6,15 @@
 
 use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;
-use Rector\Exception\Configuration\RectorRuleShouldNotBeAppliedException;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Rector\Tests\Issues\ScopeNotAvailable\Variable\ArrayItemForeachValueRector;
 
 final class ForeachValueScopeTest extends AbstractRectorTestCase
 {
     #[DataProvider('provideData')]
     public function test(string $filePath): void
     {
-        $this->expectException(RectorRuleShouldNotBeAppliedException::class);
-        $this->doTestFile($filePath);
+        $this->doTestFileExpectingWarningAboutRuleApplied($filePath, ArrayItemForeachValueRector::class);
     }
 
     public static function provideData(): Iterator

tests/Issues/ScopeNotAvailable/ForeachValueScopeTest.php

@@ -6,22 +6,15 @@
 
 use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;
-use Rector\Exception\Configuration\RectorRuleShouldNotBeAppliedException;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Rector\Tests\Testing\RectorRuleShouldNotBeApplied\Source\NoChangeRector;
 
 final class RectorRuleShouldNotBeAppliedTest extends AbstractRectorTestCase
 {
     #[DataProvider('provideData')]
     public function test(string $filePath): void
     {
-        $this->expectException(RectorRuleShouldNotBeAppliedException::class);
-        $this->expectExceptionMessage(
-            'Failed on fixture file "no_change.php.inc"' . PHP_EOL . PHP_EOL
-            . 'File not changed but some Rector rules applied:' . PHP_EOL
-            . ' * Rector\Tests\Testing\RectorRuleShouldNotBeApplied\Source\NoChangeRector'
-        );
-
-        $this->doTestFile($filePath);
+        $this->doTestFileExpectingWarningAboutRuleApplied($filePath, NoChangeRector::class);
     }
 
     public static function provideData(): Iterator