Skip null pass in ClassMethodArrayDocblockParamFromLocalCallsRector, as array param type declaration is already checked (#7336)

Author: TomasVotruba

rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/remove_nullable.php.inc

@@ -0,0 +1,54 @@
+<?php
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\Class_\ClassMethodArrayDocblockParamFromLocalCallsRector\Fixture;
+
+final class RemoveNullable
+{
+    public function go()
+    {
+        $this->run($this->getNames());
+    }
+
+    private function run(array $items)
+    {
+    }
+
+    /**
+     * @return string[]|null
+     */
+    private function getNames(): ?array
+    {
+        return ['Jim', 'Rohn'];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\Class_\ClassMethodArrayDocblockParamFromLocalCallsRector\Fixture;
+
+final class RemoveNullable
+{
+    public function go()
+    {
+        $this->run($this->getNames());
+    }
+
+    /**
+     * @param string[] $items
+     */
+    private function run(array $items)
+    {
+    }
+
+    /**
+     * @return string[]|null
+     */
+    private function getNames(): ?array
+    {
+        return ['Jim', 'Rohn'];
+    }
+}
+
+?>

rules/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector.php

@@ -9,6 +9,7 @@
 use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\PhpParser\NodeFinder\LocalMethodCallFinder;
 use Rector\Rector\AbstractRector;
@@ -112,10 +113,14 @@ public function refactor(Node $node): ?Node
                 if (! $resolvedParameterType instanceof Type) {
                     continue;
                 }
+
                 if ($resolvedParameterType instanceof MixedType) {
                     continue;
                 }
 
+                // in case of array type declaration, null cannot be passed or is already casted
+                $resolvedParameterType = TypeCombinator::removeNull($resolvedParameterType);
+
                 $hasClassMethodChanged = $this->nodeDocblockTypeDecorator->decorateGenericIterableParamType(
                     $resolvedParameterType,
                     $classMethodPhpDocInfo,