[Php71] Handle crash on partial destruct on assign var on ListToArrayDestructRector (#7909)

* [Php71] Handle crash on partial destruct on ListToArrayDestructRector

* fix

Author: samsonasik

rules-tests/Php71/Rector/List_/ListToArrayDestructRector/Fixture/skip_partial_destruct.php.inc

@@ -0,0 +1,10 @@
+<?php
+
+namespace Rector\Tests\Php71\Rector\List_\ListToArrayDestructRector\Fixture;
+
+final class SkipPartialDestruct
+{
+    public function modify_shipping_rate_cost($cost, $rate) {
+       list(, $instance_id) = explode(':', $rate->id);
+    }
+}

rules/Php71/Rector/List_/ListToArrayDestructRector.php

@@ -5,6 +5,7 @@
 namespace Rector\Php71\Rector\List_;
 
 use PhpParser\Node;
+use PhpParser\Node\ArrayItem;
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\List_;
@@ -78,6 +79,11 @@ public function refactor(Node $node): ?Node
 
             $list = $node->var;
 
+            // all list items must be set
+            if ($this->hasPartialDestruct($list)) {
+                return null;
+            }
+
             $node->var = new Array_($list->items);
             return $node;
         }
@@ -93,17 +99,26 @@ public function refactor(Node $node): ?Node
         $list = $node->valueVar;
 
         // all list items must be set
-        foreach ($list->items as $listItem) {
-            if ($listItem === null) {
-                return null;
-            }
+        if ($this->hasPartialDestruct($list)) {
+            return null;
         }
 
         $node->valueVar = new Array_($list->items);
 
         return $node;
     }
 
+    private function hasPartialDestruct(List_ $list): bool
+    {
+        foreach ($list->items as $listItem) {
+            if (! $listItem instanceof ArrayItem) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     public function provideMinPhpVersion(): int
     {
         return PhpVersionFeature::ARRAY_DESTRUCT;