remove cs from preload

Author: TomasVotruba

build/build-preload.php

@@ -51,17 +51,28 @@ final class PreloadBuilder
 
 declare(strict_types=1);
 
+use PhpParser\Node;
+use PHPStan\Testing\PHPStanTestCase;
+
 if (defined('__PHPSTAN_RUNNING__')) {
     return;
 }
 
 // edge case during Rector tests case, happens when
 // 1. phpstan autoload test case is triggered first,
 // 2. all php-parser classes are loaded,
-if (defined('PHPUNIT_COMPOSER_INSTALL') && class_exists(\PHPStan\Testing\PHPStanTestCase::class, false) && interface_exists(\PhpParser\Node::class, false)) {
+if (defined('PHPUNIT_COMPOSER_INSTALL') && isPHPStanTestPreloaded()) {
     return;
 }
 
+function isPHPStanTestPreloaded(): bool
+{
+    if (! class_exists(PHPStanTestCase::class, false)) {
+        return false;
+    }
+
+    return interface_exists(Node::class, false);
+}
 CODE_SAMPLE;
 
     /**

ecs.php

@@ -24,6 +24,9 @@
         '*/Fixture/*',
         '*/Expected/*',
 
+        // avoid re-running on build
+        __DIR__ . '/preload.php',
+
         PhpdocTypesFixer::class => [
             // double to Double false positive
             __DIR__ . '/rules/Php74/Rector/Double/RealToFloatTypeCastRector.php',

preload-split-package.php

@@ -12,14 +12,18 @@
 // edge case during Rector tests case, happens when
 // 1. phpstan autoload test case is triggered first,
 // 2. all php-parser classes are loaded,
-if (defined('PHPUNIT_COMPOSER_INSTALL') && class_exists(
-    PHPStanTestCase::class,
-    false
-) && interface_exists(Node::class, false)) {
+if (defined('PHPUNIT_COMPOSER_INSTALL') && isPHPStanTestPreloaded()) {
     return;
 }
 
-require_once __DIR__ . '/../../../vendor/nikic/php-parser/lib/PhpParser/Node.php';
+function isPHPStanTestPreloaded(): bool
+{
+    if (! class_exists(PHPStanTestCase::class, false)) {
+        return false;
+    }
+
+    return interface_exists(Node::class, false);
+}require_once __DIR__ . '/../../../vendor/nikic/php-parser/lib/PhpParser/Node.php';
 require_once __DIR__ . '/src/Contract/PhpParser/Node/StmtsAwareInterface.php';
 require_once __DIR__ . '/../../../vendor/nikic/php-parser/lib/PhpParser/NodeAbstract.php';
 require_once __DIR__ . '/../../../vendor/nikic/php-parser/lib/PhpParser/Node/Expr.php';

preload.php

@@ -12,14 +12,18 @@
 // edge case during Rector tests case, happens when
 // 1. phpstan autoload test case is triggered first,
 // 2. all php-parser classes are loaded,
-if (defined('PHPUNIT_COMPOSER_INSTALL') && class_exists(
-    PHPStanTestCase::class,
-    false
-) && interface_exists(Node::class, false)) {
+if (defined('PHPUNIT_COMPOSER_INSTALL') && isPHPStanTestPreloaded()) {
     return;
 }
 
-require_once __DIR__ . '/vendor/nikic/php-parser/lib/PhpParser/Node.php';
+function isPHPStanTestPreloaded(): bool
+{
+    if (! class_exists(PHPStanTestCase::class, false)) {
+        return false;
+    }
+
+    return interface_exists(Node::class, false);
+}require_once __DIR__ . '/vendor/nikic/php-parser/lib/PhpParser/Node.php';
 require_once __DIR__ . '/src/Contract/PhpParser/Node/StmtsAwareInterface.php';
 require_once __DIR__ . '/vendor/nikic/php-parser/lib/PhpParser/NodeAbstract.php';
 require_once __DIR__ . '/vendor/nikic/php-parser/lib/PhpParser/Node/Expr.php';