fix

Author: samsonasik

phpstan.neon

@@ -345,14 +345,3 @@ parameters:
         -
             identifier: symplify.noReference
             message: '#Use explicit return value over magic &reference#'
-
-        # known type
-        -
-            identifier: argument.type
-            message: '#Parameter \#1 \$expr of method Rector\\CodeQuality\\Rector\\BooleanOr\\RepeatedOrEqualToInArrayRector\:\:matchComparedExprAndValueExpr\(\) expects PhpParser\\Node\\Expr\\BinaryOp\\Equal\|PhpParser\\Node\\Expr\\BinaryOp\\Identical, PhpParser\\Node\\Expr given#'
-
-        -
-            path: rules/Renaming/Rector/Name/RenameClassRector.php
-            identifier: return.type
-
-        - '#Method Rector\\(.*?)Rector\:\:refactor\(\) never returns \d so it can be removed from the return type#'

rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php

@@ -17,6 +17,7 @@
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\CodeQuality\Rector\BooleanOr\RepeatedOrEqualToInArrayRector\RepeatedOrEqualToInArrayRectorTest
@@ -107,8 +108,13 @@ public function refactor(Node $node): ?FuncCall
         return new FuncCall(new Name('in_array'), $args);
     }
 
-    private function findIdenticalsOrEquals(BooleanOr $booleanOr, string $type = Identical::class): array
+    /**
+     * @return array<Identical|Equal>
+     */
+    private function findIdenticalsOrEquals(BooleanOr $booleanOr, string $type): array
     {
+        Assert::oneOf($type, [Identical::class, Equal::class]);
+
         $identicalsOrEquals = [];
         if ($booleanOr->left instanceof $type) {
             $identicalsOrEquals[] = $booleanOr->left;
@@ -122,6 +128,7 @@ private function findIdenticalsOrEquals(BooleanOr $booleanOr, string $type = Ide
             $identicalsOrEquals[] = $booleanOr->right;
         }
 
+        /** @var array<Identical|Equal> $identicalsOrEquals */
         return $identicalsOrEquals;
     }
 
@@ -172,7 +179,9 @@ private function matchComparedAndDesiredValues(BooleanOr $booleanOr): ?array
                 return null;
             }
 
-            $comparedExprAndValueExprs[] = $this->matchComparedExprAndValueExpr($currentBooleanOr->left->right);
+            /** @var Identical|Equal $leftRight */
+            $leftRight = $currentBooleanOr->left->right;
+            $comparedExprAndValueExprs[] = $this->matchComparedExprAndValueExpr($leftRight);
             $currentBooleanOr = $currentBooleanOr->left;
         }