[Php83] Fix infinite add - remove #[Override] on tearDown() method on AddOverrideAttributeToOverriddenMethodsRector when combined with NoSetupWithParentCallOverrideRector (#7903)

Author: samsonasik

rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector/Fixture/skip_teardown_override.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector\Fixture;
+
+use Rector\Tests\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector\Source\SomeAbstractTestCase;
+
+final class SkipTearDownOverrideTest extends SomeAbstractTestCase
+{
+    protected function tearDown(): void
+    {
+        parent::tearDown();
+        $result = null;
+    }
+}

rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector/Source/SomeAbstractTestCase.php

@@ -10,4 +10,9 @@ protected function setUp(): void
     {
         $value = 1000;
     }
+
+    protected function tearDown(): void
+    {
+        $value = null;
+    }
 }

rules/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector.php

@@ -246,7 +246,7 @@ private function shouldSkipClassMethod(ClassMethod $classMethod): bool
         }
 
         // skip test setup method override, as rather clutters the code than helps
-        return $this->isName($classMethod, 'setUp') && $this->parentClassAnalyzer->hasParentCall($classMethod);
+        return $this->isNames($classMethod, ['setUp', 'tearDown']) && $this->parentClassAnalyzer->hasParentCall($classMethod);
     }
 
     private function shouldSkipParentClassMethod(ClassReflection $parentClassReflection, ClassMethod $classMethod): bool