[perf] [experiment] preload all node classes once at start

Author: TomasVotruba

phpstan.neon

@@ -379,3 +379,5 @@ parameters:
         -
             message: '#Property Rector\\PhpParser\\NodeTraverser\\AbstractImmutableNodeTraverser\:\:\$visitors \(list<PhpParser\\NodeVisitor>\) does not accept array<int\|string, PhpParser\\NodeVisitor>#'
             path: src/PhpParser/NodeTraverser/AbstractImmutableNodeTraverser.php
+
+        - '#Method Rector\\Bridge\\PhpParser\\NodeClassFinder\:\:find\(\) should return array<class\-string<PhpParser\\Node>> but returns array<class\-string>#'

src/Bridge/PhpParser/NodeClassFinder.php

@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Bridge\PhpParser;
+
+use Nette\Loaders\RobotLoader;
+use ReflectionClass;
+
+final class NodeClassFinder
+{
+    /**
+     * @return array<class-string<\PhpParser\Node>>
+     */
+    public static function find(): array
+    {
+        $robotLoader = new RobotLoader();
+        $robotLoader->acceptFiles = ['*.php'];
+
+        $phpParserNodeDirectory = __DIR__ . '/../../../vendor/nikic/php-parser/lib/PhpParser/Node/';
+        $robotLoader->addDirectory($phpParserNodeDirectory);
+
+        $robotLoader->setTempDirectory(sys_get_temp_dir() . '/node-classes');
+        $robotLoader->refresh();
+
+        /** @var array<class-string> $nodeClasses */
+        $nodeClasses = array_keys($robotLoader->getIndexedClasses());
+
+        return array_filter($nodeClasses, function (string $nodeClass): bool {
+            $nodeClassReflection = new ReflectionClass($nodeClass);
+            if ($nodeClassReflection->isAbstract()) {
+                return false;
+            }
+
+            return ! $nodeClassReflection->isInterface();
+        });
+    }
+}

src/Configuration/ConfigurationRuleFilter.php

@@ -31,7 +31,7 @@ public function filter(array $rectors): array
 
         $onlyRule = $this->configuration->getOnlyRule();
         if ($onlyRule !== null) {
-            return $this->filterOnlyRule($rectors, $onlyRule);
+            return [$onlyRule];
         }
 
         return $rectors;
@@ -46,7 +46,7 @@ public function filterOnlyRule(array $rectors, string $onlyRule): array
         $activeRectors = [];
         foreach ($rectors as $rector) {
             if ($rector instanceof $onlyRule) {
-                $activeRectors[] = $rector;
+                return [$rector];
             }
         }
 

src/PhpParser/NodeTraverser/RectorNodeTraverser.php

@@ -10,6 +10,7 @@
 use Rector\Configuration\ConfigurationRuleFilter;
 use Rector\Contract\Rector\RectorInterface;
 use Rector\VersionBonding\PhpVersionedFilter;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\PhpParser\NodeTraverser\RectorNodeTraverserTest
@@ -63,22 +64,9 @@ public function refreshPhpRectors(array $rectors): void
      */
     public function getVisitorsForNode(Node $node): array
     {
-        $nodeClass = $node::class;
+        Assert::true($this->areNodeVisitorsPrepared);
 
-        if (! isset($this->visitorsPerNodeClass[$nodeClass])) {
-            $this->visitorsPerNodeClass[$nodeClass] = [];
-            /** @var RectorInterface $visitor */
-            foreach ($this->visitors as $visitor) {
-                foreach ($visitor->getNodeTypes() as $nodeType) {
-                    if (is_a($nodeClass, $nodeType, true)) {
-                        $this->visitorsPerNodeClass[$nodeClass][] = $visitor;
-                        continue 2;
-                    }
-                }
-            }
-        }
-
-        return $this->visitorsPerNodeClass[$nodeClass];
+        return $this->visitorsPerNodeClass[$node::class] ?? [];
     }
 
     /**
@@ -97,6 +85,21 @@ private function prepareNodeVisitors(): void
         // filter by configuration
         $this->visitors = $this->configurationRuleFilter->filter($this->visitors);
 
+        // static $counter = 0;
+
+        // 1. get all node non-interface, non-abstract classes
+        // 2. iterate through them
+        foreach (\Rector\Bridge\PhpParser\NodeClassFinder::find() as $nodeClass) {
+            /** @var RectorInterface $visitor */
+            foreach ($this->visitors as $visitor) {
+                foreach ($visitor->getNodeTypes() as $matchingNodeType) {
+                    if (is_a($nodeClass, $matchingNodeType, true)) {
+                        $this->visitorsPerNodeClass[$nodeClass][] = $visitor;
+                    }
+                }
+            }
+        }
+
         $this->areNodeVisitorsPrepared = true;
     }
 }

src/ValueObject/Configuration.php

@@ -7,6 +7,7 @@
 use Rector\ChangesReporting\Output\ConsoleOutputFormatter;
 use Rector\Configuration\Option;
 use Rector\Configuration\Parameter\SimpleParameterProvider;
+use Rector\Contract\Rector\RectorInterface;
 use Rector\ValueObject\Configuration\LevelOverflow;
 use Webmozart\Assert\Assert;
 
@@ -61,6 +62,9 @@ public function getFileExtensions(): array
         return $this->fileExtensions;
     }
 
+    /**
+     * @return class-string<RectorInterface>|null
+     */
     public function getOnlyRule(): ?string
     {
         return $this->onlyRule;