[Php85] Do not convert to pipe on use directly of spread operator on NestedFuncCallsToPipeOperatorRector (#7938)

* Create spread_operator_stays.php.inc

The spread operator should not be removed when changing to pipe operator

* [Php85] Do not convert to pipe on use directly of spread operator on NestedFuncCallsToPipeOperatorRector

* [ci-review] Rector Rectify

* final touch: return

---------

Co-authored-by: Anna Damm [CHECK24] <167064895+annadamm-check24@users.noreply.github.com>
Co-authored-by: GitHub Action <actions@github.com>

Author: 3 people

rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/spread_operator_stays.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;
+
+$arrayOfArrays = [['a'], ['a'], ['b']];
+$merged = array_unique(array_merge(...$arrayOfArrays));
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;
+
+$arrayOfArrays = [['a'], ['a'], ['b']];
+$merged = array_merge(...$arrayOfArrays)
+    |> array_unique(...);
+
+?>

rules/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector.php

@@ -145,6 +145,11 @@ private function processNestedCalls(Expr $expr, bool $deep = false): ?Expr
 
             // If we're deep in recursion and hit a non-FuncCall, this is the base
             if ($deep) {
+                // Spread argument can't be converted to pipe — keep the call as-is
+                if ($arg->unpack) {
+                    return null;
+                }
+
                 // Return a pipe with the base expression on the left
                 return new Pipe($arg->value, $this->createPlaceholderCall($expr));
             }

src/ChangesReporting/Output/JUnitOutputFormatter.php

@@ -57,16 +57,16 @@ public function report(ProcessResult $processResult, Configuration $configuratio
 
         $domDocument = new DOMDocument('1.0', 'UTF-8');
 
-        $xmlTestSuite = $domDocument->createElement(self::XML_ELEMENT_TESTSUITE);
-        $xmlTestSuite->setAttribute(self::XML_ATTRIBUTE_NAME, 'rector');
+        $domElement = $domDocument->createElement(self::XML_ELEMENT_TESTSUITE);
+        $domElement->setAttribute(self::XML_ATTRIBUTE_NAME, 'rector');
 
         $xmlTestSuites = $domDocument->createElement(self::XML_ELEMENT_TESTSUITES);
-        $xmlTestSuites->appendChild($xmlTestSuite);
+        $xmlTestSuites->appendChild($domElement);
 
         $domDocument->appendChild($xmlTestSuites);
 
-        $this->appendSystemErrors($processResult, $configuration, $domDocument, $xmlTestSuite);
-        $this->appendFileDiffs($processResult, $configuration, $domDocument, $xmlTestSuite);
+        $this->appendSystemErrors($processResult, $configuration, $domDocument, $domElement);
+        $this->appendFileDiffs($processResult, $configuration, $domDocument, $domElement);
 
         echo $domDocument->saveXML() . PHP_EOL;
     }