[dx] split of TypeDeclarationDocblockLevel

Author: TomasVotruba

config/set/type-declaration-docblocks.php

@@ -3,46 +3,10 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnArrayDocblockBasedOnArrayMapRector;
-use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnDocblockForScalarArrayFromAssignsRector;
-use Rector\TypeDeclarationDocblocks\Rector\Class_\AddReturnDocblockDataProviderRector;
-use Rector\TypeDeclarationDocblocks\Rector\Class_\ClassMethodArrayDocblockParamFromLocalCallsRector;
-use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarArrayFromGetterReturnRector;
-use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarArrayFromPropertyDefaultsRector;
-use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarFromParamDocblockInConstructorRector;
-use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDataProviderRector;
-use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDimFetchAccessRector;
-use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForArrayDimAssignedObjectRector;
-use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForCommonObjectDenominatorRector;
-use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForJsonArrayRector;
-use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockGetterReturnArrayFromPropertyDocblockVarRector;
-use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockReturnArrayFromDirectArrayInstanceRector;
 
 /**
  * @experimental * 2025-09, experimental hidden set for type declaration in docblocks
  */
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        // property var
-        DocblockVarFromParamDocblockInConstructorRector::class,
-        DocblockVarArrayFromPropertyDefaultsRector::class,
-        DocblockVarArrayFromGetterReturnRector::class,
-
-        // param
-        AddParamArrayDocblockFromDimFetchAccessRector::class,
-        ClassMethodArrayDocblockParamFromLocalCallsRector::class,
-
-        // return
-        DocblockGetterReturnArrayFromPropertyDocblockVarRector::class,
-        AddReturnDocblockForCommonObjectDenominatorRector::class,
-        AddReturnArrayDocblockBasedOnArrayMapRector::class,
-        AddReturnDocblockForScalarArrayFromAssignsRector::class,
-        DocblockReturnArrayFromDirectArrayInstanceRector::class,
-        AddReturnDocblockForArrayDimAssignedObjectRector::class,
-        AddReturnDocblockForJsonArrayRector::class,
-
-        // tests
-        AddParamArrayDocblockFromDataProviderRector::class,
-        AddReturnDocblockDataProviderRector::class,
-    ]);
+    $rectorConfig->rules(\Rector\Config\Level\TypeDeclarationDocblockLevel::RULES);
 };

src/ChangesReporting/ValueObjectFactory/FileDiffFactory.php

@@ -36,11 +36,6 @@ public function createFileDiffWithLineChanges(
         $consoleDiff = $shouldShowDiffs ? $this->colorConsoleDiffFormatter->format($diff) : '';
 
         // always keep the most recent diff
-        return new FileDiff(
-            $relativeFilePath,
-            $diff,
-            $consoleDiff,
-            $rectorsWithLineChanges
-        );
+        return new FileDiff($relativeFilePath, $diff, $consoleDiff, $rectorsWithLineChanges);
     }
 }

src/Config/Level/TypeDeclarationDocblockLevel.php

@@ -0,0 +1,57 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Config\Level;
+
+use Rector\Contract\Rector\RectorInterface;
+use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnArrayDocblockBasedOnArrayMapRector;
+use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnDocblockForScalarArrayFromAssignsRector;
+use Rector\TypeDeclarationDocblocks\Rector\Class_\AddReturnDocblockDataProviderRector;
+use Rector\TypeDeclarationDocblocks\Rector\Class_\ClassMethodArrayDocblockParamFromLocalCallsRector;
+use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarArrayFromGetterReturnRector;
+use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarArrayFromPropertyDefaultsRector;
+use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarFromParamDocblockInConstructorRector;
+use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDataProviderRector;
+use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDimFetchAccessRector;
+use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForArrayDimAssignedObjectRector;
+use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForCommonObjectDenominatorRector;
+use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForJsonArrayRector;
+use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockGetterReturnArrayFromPropertyDocblockVarRector;
+use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockReturnArrayFromDirectArrayInstanceRector;
+
+final class TypeDeclarationDocblockLevel
+{
+    /**
+     * @var array<class-string<RectorInterface>>
+     */
+    public const RULES = [
+        // start with rules based on native code
+        // property var
+        DocblockVarArrayFromPropertyDefaultsRector::class,
+
+        // tests
+        AddParamArrayDocblockFromDataProviderRector::class,
+        AddReturnDocblockDataProviderRector::class,
+
+        // param
+        AddParamArrayDocblockFromDimFetchAccessRector::class,
+        ClassMethodArrayDocblockParamFromLocalCallsRector::class,
+
+        // return
+        AddReturnDocblockForCommonObjectDenominatorRector::class,
+        AddReturnArrayDocblockBasedOnArrayMapRector::class,
+        AddReturnDocblockForScalarArrayFromAssignsRector::class,
+        DocblockReturnArrayFromDirectArrayInstanceRector::class,
+        AddReturnDocblockForArrayDimAssignedObjectRector::class,
+        AddReturnDocblockForJsonArrayRector::class,
+
+        // move to rules based on existing docblocks, as more risky
+        // property var
+        DocblockVarFromParamDocblockInConstructorRector::class,
+        DocblockVarArrayFromGetterReturnRector::class,
+
+        // return
+        DocblockGetterReturnArrayFromPropertyDocblockVarRector::class,
+    ];
+}