fix

Author: samsonasik

rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_equal_numeric_string.php.inc

@@ -9,7 +9,10 @@ final class SkipIdenticalNumericStringCompareBool
 {
     public function equal()
     {
-        var_dump(true == '1');
-        var_dump('1' == true);
+        // maybe compare to numeric string
+        $value = rand(0, 1) ? '1' : null;
+
+        var_dump(true == $value);
+        var_dump($value == true);
     }
 }

rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php

@@ -103,12 +103,13 @@ public function refactor(Node $node): ?Node
 
     private function shouldSkipCompareNumericString(Type $leftStaticType, Type $rightStaticType): bool
     {
+        // use ! ->no() as to support both yes and maybe
         if ($leftStaticType instanceof BooleanType) {
-            return $rightStaticType->isNumericString()->yes();
+            return ! $rightStaticType->isNumericString()->no();
         }
 
         if ($rightStaticType instanceof BooleanType) {
-            return $leftStaticType->isNumericString()->yes();
+            return ! $leftStaticType->isNumericString()->no();
         }
 
         return false;