misc

Author: TomasVotruba

phpstan.neon

@@ -5,7 +5,7 @@ includes:
 parameters:
     level: 8
 
-    reportUnmatchedIgnoredErrors: false
+    # reportUnmatchedIgnoredErrors: false
     errorFormat: symplify
 
     # see https://phpstan.org/writing-php-code/phpdoc-types#global-type-aliases
@@ -48,7 +48,12 @@ parameters:
         narrow_return: true
 
     ignoreErrors:
+        # required generics on interface array, not helpful
         -
+            message: '#Method (.*?)\:\:__construct\(\) has parameter#'
+            identifier: missingType.generics
+        -
+            message: '#(.*?) with generic interface (.*?)Interface does not specify its types#'
             identifier: missingType.generics
 
         # phpstan class instance
@@ -334,12 +339,6 @@ parameters:
             identifier: arrayValues.list
             path: rules/CodingStyle/Application/UseImportsAdder.php
 
-        -
-            message: '#^Register "Rector\\Php74\\Rector\\Double\\RealToFloatTypeCastRector" service to "php74\.php" config set$#'
-            identifier: rector.upgradeDowngradeRegisteredInSet
-            count: 1
-            path: rules/Php74/Rector/Double/RealToFloatTypeCastRector.php
-
         -
             message: '#Offset float\|int\|string might not exist on string#'
             path: rules/Php70/EregToPcreTransformer.php
@@ -387,14 +386,11 @@ parameters:
         -
             paths:
                 - rules/TypeDeclaration/Rector/StmtsAwareInterface/IncreaseDeclareStrictTypesRector.php
-                - rules/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector.php
             identifier: rector.noOnlyNullReturnInRefactor
 
         -
             identifier: rector.noIntegerRefactorReturn
             paths:
-                - rules/Transform/Rector/ArrayDimFetch/ArrayDimFetchToMethodCallRector.php
-
                 # valid, as use REMOVE_NODE
                 - rules/DeadCode/Rector/Expression/RemoveDeadStmtRector.php
                 - rules/DeadCode/Rector/If_/RemoveDeadInstanceOfRector.php

src/PhpParser/NodeTraverser/AbstractImmutableNodeTraverser.php

@@ -81,11 +81,6 @@ public function traverse(array $nodes): array
      */
     abstract public function getVisitorsForNode(Node $node): array;
 
-    /**
-     * Recursively traverse a node.
-     *
-     * @param Node $node Node to traverse.
-     */
     protected function traverseNode(Node $node): void
     {
         foreach ($node->getSubNodeNames() as $name) {
@@ -164,10 +159,7 @@ protected function traverseNode(Node $node): void
     }
 
     /**
-     * Recursively traverse array (usually of nodes).
-     *
-     * @param Node[] $nodes Array to traverse
-     *
+     * @param Node[] $nodes
      * @return array Result of traversal (may be original array or changed one)
      */
     protected function traverseArray(array $nodes): array