extract LaravelClassName

Author: TomasVotruba

rules-tests/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector/Fixture/skip_protected_magic_called_from_parent.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector\Fixture;
+
+use PhpParser\PrettyPrinter\Standard;
+use Rector\PhpParser\Node\FileNode;
+
+final class KeepMagicParentCalledMethod extends Standard
+{
+    // called from parent by $this->{'p'} method
+    protected function pFileNode(FileNode $fileNode)
+    {
+    }
+}

rules-tests/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector/Fixture/keep_magic_parent_called_method.php.inc

@@ -8,6 +8,7 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Type\ObjectType;
+use Rector\Enum\LaravelClassName;
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer;
@@ -39,7 +40,7 @@ public function __construct(
 
     public function isProtectedMethod(ClassReflection $classReflection, ClassMethod $classMethod): bool
     {
-        if (! $classReflection->is('Illuminate\Database\Eloquent\Model')) {
+        if (! $classReflection->is(LaravelClassName::MODEL)) {
             return false;
         }
 
@@ -63,7 +64,7 @@ private function isAttributeMethod(string $name, ClassMethod $classMethod): bool
 
         return $this->nodeTypeResolver->isObjectType(
             $classMethod->returnType,
-            new ObjectType('Illuminate\Database\Eloquent\Casts\Attribute')
+            new ObjectType(LaravelClassName::CAST_ATTRIBUTE)
         );
     }
 
@@ -73,9 +74,6 @@ private function isScopeMethod(string $name, ClassMethod $classMethod): bool
             return true;
         }
 
-        return $this->phpAttributeAnalyzer->hasPhpAttribute(
-            $classMethod,
-            'Illuminate\Database\Eloquent\Attributes\Scope'
-        );
+        return $this->phpAttributeAnalyzer->hasPhpAttribute($classMethod, LaravelClassName::ATTRIBUTES_SCOPE);
     }
 }

rules/Privatization/Guard/LaravelModelGuard.php

@@ -83,6 +83,7 @@ public function refactor(Node $node): ?Node
         }
 
         $scope = ScopeFetcher::fetch($node);
+
         $classReflection = $scope->getClassReflection();
         if (! $classReflection instanceof ClassReflection) {
             return null;

rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Enum;
+
+final class LaravelClassName
+{
+    public const MODEL = 'Illuminate\Database\Eloquent\Model';
+
+    public const CAST_ATTRIBUTE = 'Illuminate\Database\Eloquent\Casts\Attribute';
+
+    public const ATTRIBUTES_SCOPE = 'Illuminate\Database\Eloquent\Attributes\Scope';
+}