[Rectify] [Php81] Enable Rectify on Readonly Property only (#1384)

* re-enable rectify and ecs

* [Rectify] [Php81] Enable Rectify on Readonly Property only

* comment

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: GitHub Action <action@github.com>

Author: samsonasik

.github/workflows/rector.yaml

@@ -57,10 +57,9 @@ jobs:
             -   run: composer install --no-progress --ansi
 
             ## First run Rector - here can't be --dry-run !!! it would stop the job with it and not commit anything in the future
-            # temporary disable rectify as splitted from https://github.com/rectorphp/rector-src/pull/1364
-            # -   run: bin/rector process ${{ matrix.paths }} --ansi --no-progress-bar
+            -   run: bin/rector process ${{ matrix.paths }} --ansi --no-progress-bar
 
-            # -   run: vendor/bin/ecs check --fix --ansi
+            -   run: vendor/bin/ecs check --fix --ansi
 
             # see https://github.com/EndBug/add-and-commit
             -

packages/BetterPhpDocParser/Comment/CommentsMerger.php

@@ -12,7 +12,7 @@
 final class CommentsMerger
 {
     public function __construct(
-        private SimpleCallableNodeTraverser $simpleCallableNodeTraverser
+        private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser
     ) {
     }
 

packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php

@@ -49,19 +49,19 @@ final class PhpDocInfo
 
     private bool $isSingleLine = false;
 
-    private PhpDocNode $originalPhpDocNode;
+    private readonly PhpDocNode $originalPhpDocNode;
 
     private bool $hasChanged = false;
 
     public function __construct(
-        private PhpDocNode $phpDocNode,
-        private BetterTokenIterator $betterTokenIterator,
-        private StaticTypeMapper $staticTypeMapper,
-        private \PhpParser\Node $node,
-        private AnnotationNaming $annotationNaming,
-        private CurrentNodeProvider $currentNodeProvider,
-        private RectorChangeCollector $rectorChangeCollector,
-        private PhpDocNodeByTypeFinder $phpDocNodeByTypeFinder
+        private readonly PhpDocNode $phpDocNode,
+        private readonly BetterTokenIterator $betterTokenIterator,
+        private readonly StaticTypeMapper $staticTypeMapper,
+        private readonly \PhpParser\Node $node,
+        private readonly AnnotationNaming $annotationNaming,
+        private readonly CurrentNodeProvider $currentNodeProvider,
+        private readonly RectorChangeCollector $rectorChangeCollector,
+        private readonly PhpDocNodeByTypeFinder $phpDocNodeByTypeFinder
     ) {
         $this->originalPhpDocNode = clone $phpDocNode;
 

packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfoFactory.php

@@ -28,14 +28,14 @@ final class PhpDocInfoFactory
     private array $phpDocInfosByObjectHash = [];
 
     public function __construct(
-        private PhpDocNodeMapper $phpDocNodeMapper,
-        private CurrentNodeProvider $currentNodeProvider,
-        private Lexer $lexer,
-        private BetterPhpDocParser $betterPhpDocParser,
-        private StaticTypeMapper $staticTypeMapper,
-        private AnnotationNaming $annotationNaming,
-        private RectorChangeCollector $rectorChangeCollector,
-        private PhpDocNodeByTypeFinder $phpDocNodeByTypeFinder
+        private readonly PhpDocNodeMapper $phpDocNodeMapper,
+        private readonly CurrentNodeProvider $currentNodeProvider,
+        private readonly Lexer $lexer,
+        private readonly BetterPhpDocParser $betterPhpDocParser,
+        private readonly StaticTypeMapper $staticTypeMapper,
+        private readonly AnnotationNaming $annotationNaming,
+        private readonly RectorChangeCollector $rectorChangeCollector,
+        private readonly PhpDocNodeByTypeFinder $phpDocNodeByTypeFinder
     ) {
     }
 

packages/BetterPhpDocParser/PhpDocInfo/TokenIteratorFactory.php

@@ -17,8 +17,8 @@ final class TokenIteratorFactory
     private const INDEX = 'index';
 
     public function __construct(
-        private Lexer $lexer,
-        private PrivatesAccessor $privatesAccessor
+        private readonly Lexer $lexer,
+        private readonly PrivatesAccessor $privatesAccessor
     ) {
     }
 

packages/BetterPhpDocParser/PhpDocManipulator/PhpDocClassRenamer.php

@@ -14,7 +14,7 @@
 final class PhpDocClassRenamer
 {
     public function __construct(
-        private ClassAnnotationMatcher $classAnnotationMatcher
+        private readonly ClassAnnotationMatcher $classAnnotationMatcher
     ) {
     }
 

packages/BetterPhpDocParser/PhpDocManipulator/PhpDocTypeChanger.php

@@ -25,10 +25,10 @@
 final class PhpDocTypeChanger
 {
     public function __construct(
-        private StaticTypeMapper $staticTypeMapper,
-        private TypeComparator $typeComparator,
-        private ParamPhpDocNodeFactory $paramPhpDocNodeFactory,
-        private NodeNameResolver $nodeNameResolver
+        private readonly StaticTypeMapper $staticTypeMapper,
+        private readonly TypeComparator $typeComparator,
+        private readonly ParamPhpDocNodeFactory $paramPhpDocNodeFactory,
+        private readonly NodeNameResolver $nodeNameResolver
     ) {
     }
 

packages/BetterPhpDocParser/PhpDocManipulator/PropertyDocBlockManipulator.php

@@ -13,7 +13,7 @@
 final class PropertyDocBlockManipulator
 {
     public function __construct(
-        private PhpDocInfoFactory $phpDocInfoFactory
+        private readonly PhpDocInfoFactory $phpDocInfoFactory
     ) {
     }
 

packages/BetterPhpDocParser/PhpDocManipulator/VarAnnotationManipulator.php

@@ -18,8 +18,8 @@
 final class VarAnnotationManipulator
 {
     public function __construct(
-        private PhpDocInfoFactory $phpDocInfoFactory,
-        private PhpDocTypeChanger $phpDocTypeChanger
+        private readonly PhpDocInfoFactory $phpDocInfoFactory,
+        private readonly PhpDocTypeChanger $phpDocTypeChanger
     ) {
     }
 

packages/BetterPhpDocParser/PhpDocNodeMapper.php

@@ -21,10 +21,10 @@ final class PhpDocNodeMapper
      * @param BasePhpDocNodeVisitorInterface[] $phpDocNodeVisitors
      */
     public function __construct(
-        private CurrentTokenIteratorProvider $currentTokenIteratorProvider,
-        private ParentConnectingPhpDocNodeVisitor $parentConnectingPhpDocNodeVisitor,
-        private CloningPhpDocNodeVisitor $cloningPhpDocNodeVisitor,
-        private array $phpDocNodeVisitors
+        private readonly CurrentTokenIteratorProvider $currentTokenIteratorProvider,
+        private readonly ParentConnectingPhpDocNodeVisitor $parentConnectingPhpDocNodeVisitor,
+        private readonly CloningPhpDocNodeVisitor $cloningPhpDocNodeVisitor,
+        private readonly array $phpDocNodeVisitors
     ) {
     }