extract logic to different method

Author: samsonasik

rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector.php

@@ -211,7 +211,6 @@ private function areConstructorAndParentParameterTypesMatching(
         ClassMethod $classMethod,
         ExtendedMethodReflection $extendedMethodReflection
     ): bool {
-        $methodName = $this->getName($classMethod);
         foreach ($classMethod->getParams() as $position => $param) {
             $parameterType = $param->type;
 
@@ -240,27 +239,38 @@ private function areConstructorAndParentParameterTypesMatching(
                     continue;
                 }
 
-                // native reflection is needed to get exact default value
-                if ($extendedMethodReflection->getDeclaringClass()->getNativeReflection()->hasMethod($methodName)) {
-                    $parentMethod = $extendedMethodReflection->getDeclaringClass()
-                        ->getNativeReflection()
-                        ->getMethod($methodName);
-                    $nativeParentParameterReflection = $parentMethod->getParameters()[$index] ?? null;
+                if ($this->isDifferentDefaultValue($param->default, $extendedMethodReflection, $index)) {
+                    return false;
+                }
+            }
+        }
 
-                    if (! $nativeParentParameterReflection instanceof ReflectionParameter) {
-                        continue;
-                    }
+        return true;
+    }
 
-                    $parentDefault = $nativeParentParameterReflection->getDefaultValue();
-                    $currentDefault = $this->valueResolver->getValue($param->default);
+    private function isDifferentDefaultValue(
+        Expr $defaultExpr,
+        ExtendedMethodReflection $extendedMethodReflection,
+        int $index
+    ): bool {
+        $methodName = $extendedMethodReflection->getName();
+        // native reflection is needed to get exact default value
+        if ($extendedMethodReflection->getDeclaringClass()->getNativeReflection()->hasMethod($methodName)) {
+            $parentMethod = $extendedMethodReflection->getDeclaringClass()
+                ->getNativeReflection()
+                ->getMethod($methodName);
+            $nativeParentParameterReflection = $parentMethod->getParameters()[$index] ?? null;
+
+            if (! $nativeParentParameterReflection instanceof ReflectionParameter) {
+                return false;
+            }
 
-                    if ($parentDefault !== $currentDefault) {
-                        return false;
-                    }
-                }
+            $parentDefault = $nativeParentParameterReflection->getDefaultValue();
+            if (! $this->valueResolver->isValue($defaultExpr, $parentDefault)) {
+                return true;
             }
         }
 
-        return true;
+        return false;
     }
 }