[Php84] Skip foreach value used after foreach on ForeachToArray* rules (#7034)

* [Php84] Skip foreach value used after foreach on ForeachToArray* rules

* more fixtures

Author: samsonasik

rules-tests/Php84/Rector/Foreach_/ForeachToArrayAllRector/Fixture/skip_variable_reuse_after_foreach.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\Foreach_\ForeachToArrayAllRector\Fixture;
+
+class SkipVariableReUseAfterForeach
+{
+    public function checkAllAnimalsStartWithC(array $animals)
+    {
+        $found = true;
+        foreach ($animals as $animal) {
+            if (!str_starts_with($animal, 'c')) {
+                $found = false;
+                break;
+            }
+        }
+
+        if (isset($animal)) {
+            echo 'hit';
+        }
+
+        return $found;
+    }
+}

rules-tests/Php84/Rector/Foreach_/ForeachToArrayAnyRector/Fixture/skip_variable_reuse_after_foreach.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\Foreach_\ForeachToArrayAnyRector\Fixture;
+
+class SkipVariableReUseAfterForeach
+{
+    public function checkAnimal(array $animals)
+    {
+        $found = false;
+        foreach ($animals as $animal) {
+            if (str_starts_with($animal, 'c')) {
+                $found = true;
+                break;
+            }
+        }
+
+        if (isset($animal)) {
+            echo 'hit';
+        }
+
+        return $found;
+    }
+}

rules-tests/Php84/Rector/Foreach_/ForeachToArrayFindKeyRector/Fixture/skip_variable_reuse_after_foreach.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\Foreach_\ForeachToArrayFindKeyRector\Fixture;
+
+class SkipVariableReUseAfterForeach
+{
+    public function findAnimalKey(array $animals)
+    {
+        $found = null;
+        foreach ($animals as $idx => $animal) {
+            if (str_starts_with($animal, 'c')) {
+                $found = $idx;
+                break;
+            }
+        }
+
+        if (isset($animal)) {
+            echo 'hit';
+        }
+
+        return $found;
+    }
+}

rules-tests/Php84/Rector/Foreach_/ForeachToArrayFindRector/Fixture/skip_variable_reuse_after_foreach.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\Foreach_\ForeachToArrayFindRector\Fixture;
+
+class SkipVariableReUseAfterForeach
+{
+    /**
+    * @param array<Url> $urls
+    */
+    public function create(array $urls, string $hash): ?Url
+    {
+        $url = null;
+        foreach ($urls as $urlToCheck) {
+            if ($urlToCheck->getPathHash() === $hash) {
+                $url = $urlToCheck;
+                break;
+            }
+        }
+
+        if (isset($urlToCheck)) {
+            echo 'hit';
+        }
+
+        return $url;
+    }
+}

rules/Php84/Rector/Foreach_/ForeachToArrayAllRector.php

@@ -15,6 +15,7 @@
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
 use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
+use Rector\NodeManipulator\StmtsManipulator;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\PhpVersionFeature;
@@ -28,7 +29,8 @@
 final class ForeachToArrayAllRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
-        private readonly ValueResolver $valueResolver
+        private readonly ValueResolver $valueResolver,
+        private readonly StmtsManipulator $stmtsManipulator
     ) {
     }
 
@@ -104,6 +106,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($this->stmtsManipulator->isVariableUsedInNextStmt($node, $key + 1, (string) $this->getName($foreach->valueVar))) {
+                continue;
+            }
+
             /** @var If_ $firstNodeInsideForeach */
             $firstNodeInsideForeach = $foreach->stmts[0];
 

rules/Php84/Rector/Foreach_/ForeachToArrayAnyRector.php

@@ -14,6 +14,7 @@
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
 use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
+use Rector\NodeManipulator\StmtsManipulator;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\PhpVersionFeature;
@@ -27,7 +28,8 @@
 final class ForeachToArrayAnyRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
-        private readonly ValueResolver $valueResolver
+        private readonly ValueResolver $valueResolver,
+        private readonly StmtsManipulator $stmtsManipulator
     ) {
     }
 
@@ -103,6 +105,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($this->stmtsManipulator->isVariableUsedInNextStmt($node, $key + 1, (string) $this->getName($foreach->valueVar))) {
+                continue;
+            }
+
             /** @var If_ $firstNodeInsideForeach */
             $firstNodeInsideForeach = $foreach->stmts[0];
 

rules/Php84/Rector/Foreach_/ForeachToArrayFindKeyRector.php

@@ -15,6 +15,7 @@
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
 use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
+use Rector\NodeManipulator\StmtsManipulator;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\PhpVersionFeature;
@@ -28,7 +29,8 @@
 final class ForeachToArrayFindKeyRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
-        private readonly ValueResolver $valueResolver
+        private readonly ValueResolver $valueResolver,
+        private readonly StmtsManipulator $stmtsManipulator,
     ) {
     }
 
@@ -108,6 +110,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($this->stmtsManipulator->isVariableUsedInNextStmt($node, $key + 1, (string) $this->getName($foreach->valueVar))) {
+                continue;
+            }
+
             /** @var If_ $firstNodeInsideForeach */
             $firstNodeInsideForeach = $foreach->stmts[0];
 

rules/Php84/Rector/Foreach_/ForeachToArrayFindRector.php

@@ -14,6 +14,7 @@
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
 use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
+use Rector\NodeManipulator\StmtsManipulator;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\PhpVersionFeature;
@@ -27,7 +28,8 @@
 final class ForeachToArrayFindRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
-        private readonly ValueResolver $valueResolver
+        private readonly ValueResolver $valueResolver,
+        private readonly StmtsManipulator $stmtsManipulator
     ) {
     }
 
@@ -103,6 +105,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($this->stmtsManipulator->isVariableUsedInNextStmt($node, $key + 1, (string) $this->getName($foreach->valueVar))) {
+                continue;
+            }
+
             /** @var If_ $firstNodeInsideForeach */
             $firstNodeInsideForeach = $foreach->stmts[0];