add isset/unset keys

Author: TomasVotruba

rules-tests/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector/Fixture/isset_unset.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\KnownMagicClassMethodTypeRector\Fixture;
+
+final class IssetUnset
+{
+    public function __isset($key): bool
+    {
+        return true;
+    }
+
+    public function __unset($key): void
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\KnownMagicClassMethodTypeRector\Fixture;
+
+final class IssetUnset
+{
+    public function __isset(string $key): bool
+    {
+        return true;
+    }
+
+    public function __unset(string $key): void
+    {
+    }
+}
+
+?>

rules/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector.php

@@ -11,12 +11,9 @@
 use Rector\Php\PhpVersionProvider;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\MethodName;
-<<<<<<< HEAD
-use Rector\VendorLocker\ParentClassMethodTypeOverrideGuard;
-=======
 use Rector\ValueObject\PhpVersionFeature;
+use Rector\VendorLocker\ParentClassMethodTypeOverrideGuard;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
->>>>>>> 971356b355 (add scalar types condition)
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -28,17 +25,12 @@
 final class KnownMagicClassMethodTypeRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
-<<<<<<< HEAD
-        private readonly ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard
-    ){
-    }
-=======
-        private readonly PhpVersionProvider $phpVersionProvider
+        private readonly ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard,
+        private readonly PhpVersionProvider $phpVersionProvider,
     ) {
 
     }
 
->>>>>>> 3a091179f1 (add call static support, set and get)
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -87,50 +79,38 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
-<<<<<<< HEAD
-            if (! $this->isName($classMethod, MethodName::CALL)) {
-                continue;
-            }
-=======
-            if ($this->isNames($classMethod, [MethodName::CALL, MethodName::CALL_STATIC])) {
-                $firstParam = $classMethod->getParams()[0];
-                if (! $firstParam->type instanceof Node) {
-                    $firstParam->type = new Identifier('string');
-                    $hasChanged = true;
-                }
->>>>>>> 3a091179f1 (add call static support, set and get)
-
             if ($this->parentClassMethodTypeOverrideGuard->hasParentClassMethod($classMethod)) {
                 return null;
             }
 
-            $firstParam = $classMethod->getParams()[0];
-            if (! $firstParam->type instanceof Node) {
-                $firstParam->type = new Identifier('string');
-                $hasChanged = true;
-            }
-
-            $secondParam = $classMethod->getParams()[1];
-            if (! $secondParam->type instanceof Node) {
-                $secondParam->type = new Name('array');
-                $hasChanged = true;
-            }
-
-            if ($this->isName($classMethod, MethodName::__GET)) {
-                $firstParam = $classMethod->getParams()[0];
-                if (! $firstParam->type instanceof Node) {
-                    $firstParam->type = new Identifier('string');
+            if ($this->isNames($classMethod, [MethodName::CALL, MethodName::CALL_STATIC])) {
+                $secondParam = $classMethod->getParams()[1];
+                if (! $secondParam->type instanceof Node) {
+                    $secondParam->type = new Name('array');
                     $hasChanged = true;
                 }
             }
 
-            if ($this->isName($classMethod, MethodName::__SET)) {
+            // first arg string
+            if ($this->isNames(
+                $classMethod,
+                [
+                    MethodName::CALL,
+                    MethodName::CALL_STATIC,
+                    MethodName::__SET,
+                    MethodName::__GET,
+                    MethodName::ISSET,
+                    MethodName::UNSET,
+                ]
+            )) {
                 $firstParam = $classMethod->getParams()[0];
                 if (! $firstParam->type instanceof Node) {
                     $firstParam->type = new Identifier('string');
                     $hasChanged = true;
                 }
+            }
 
+            if ($this->isName($classMethod, MethodName::__SET)) {
                 if ($this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::MIXED_TYPE)) {
                     $secondParam = $classMethod->getParams()[1];
                     if (! $secondParam->type instanceof Node) {

src/ValueObject/MethodName.php

@@ -77,4 +77,9 @@ final class MethodName
      * @var string
      */
     public const ISSET = '__isset';
+
+    /**
+     * @var string
+     */
+    public const UNSET = '__unset';
 }