[php 8.3] Add json_validate rule

config/set/php83.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\Php83\Rector\BooleanAnd\JsonValidateRector;
 use Rector\Php83\Rector\Class_\ReadOnlyAnonymousClassRector;
 use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
 use Rector\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector;
@@ -18,5 +19,6 @@
         RemoveGetClassGetParentClassNoArgsRector::class,
         ReadOnlyAnonymousClassRector::class,
         DynamicClassConstFetchRector::class,
+        JsonValidateRector::class,
     ]);
 };

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/Json_validate.php.inc

@@ -0,0 +1,15 @@
+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_decode($json, true) !== null && json_last_error() === JSON_ERROR_NONE){
+    echo 1;
+}
+?>
+-----
+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_validate($json)){
+    echo 1;
+}
+?>

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/Json_validate_named.php.inc

@@ -0,0 +1,15 @@
+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_decode($json, true) !== null && json_last_error() === JSON_ERROR_NONE){
+    echo 1;
+}
+?>
+-----
+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_validate($json)){
+    echo 1;
+}
+?>

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/elseif.php.inc

@@ -0,0 +1,17 @@
+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if ($flag) {
+    echo "skip";
+} elseif (json_decode($config, true) !== null && json_last_error() === JSON_ERROR_NONE) {
+    echo "valid config";
+}
+-----
+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if ($flag) {
+    echo "skip";
+} elseif (json_validate($config)) {
+    echo "valid config";
+}

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/inline_string.php.inc

@@ -0,0 +1,13 @@
+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_decode('{"a":1}', true) !== null && json_last_error() === JSON_ERROR_NONE) {
+    echo "inline";
+}
+-----
+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_validate('{"a":1}')) {
+    echo "inline";
+}

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/JsonValidateRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class JsonValidateRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/config/configured_rule.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php83\Rector\BooleanAnd\JsonValidateRector;
+use Rector\ValueObject\PhpVersion;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->phpVersion(PhpVersion::PHP_80);
+
+    $rectorConfig->rule(JsonValidateRector::class);
+};

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php

@@ -0,0 +1,120 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php83\Rector\BooleanAnd;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
+use PhpParser\Node\Expr\BinaryOp\Identical;
+use PhpParser\Node\Expr\BinaryOp\NotIdentical;
+use PhpParser\Node\Expr\ConstFetch;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Name;
+use Rector\Rector\AbstractRector;
+use Rector\ValueObject\PhpVersionFeature;
+use Rector\ValueObject\PolyfillPackage;
+use Rector\VersionBonding\Contract\MinPhpVersionInterface;
+use Rector\VersionBonding\Contract\RelatedPolyfillInterface;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * @see \Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\JsonValidateRectorTest
+ */
+final class JsonValidateRector extends AbstractRector implements MinPhpVersionInterface, RelatedPolyfillInterface
+{
+    public function provideMinPhpVersion(): int
+    {
+        return PhpVersionFeature::JSON_VALIDATE;
+    }
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Replace json_decode($json, true) !== null && json_last_error() === JSON_ERROR_NONE  with json_validate()',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+if (json_decode($json, true) !== null && json_last_error() === JSON_ERROR_NONE) {
+}
+
+CODE_SAMPLE
+                    ,
+                    <<<'CODE_SAMPLE'
+if (json_validate($json)) {
+}    
+CODE_SAMPLE
+                ),
+            ]
+        );
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [BooleanAnd::class];
+    }
+
+    /**
+     * @param BooleanAnd $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        $funcCall = $this->matchJsonValidateArg($node);
+
+        if (! $funcCall instanceof FuncCall) {
+            return null;
+        }
+
+        if ($funcCall->isFirstClassCallable()) {
+            return null;
+        }
+
+        if (isset($funcCall->getArgs()[1])) {
+            unset($funcCall->args[1]);
+        }
+
+        $funcCall->name = new Name('json_validate');
+
+        return $funcCall;
+    }
+
+    public function providePolyfillPackage(): string
+    {
+        return PolyfillPackage::PHP_80;
+    }
+
+    public function matchJsonValidateArg(BooleanAnd $booleanAnd): ?FuncCall
+    {
+        if ($booleanAnd->left instanceof NotIdentical) {
+            $notIdentical = $booleanAnd->left;
+
+            if ($notIdentical->left instanceof FuncCall
+                && $this->isName($notIdentical->left->name, 'json_decode')
+                && $notIdentical->right instanceof ConstFetch
+                && $this->isName($notIdentical->right->name, 'null')) {
+
+                // right side: json_last_error() === JSON_ERROR_NONE
+                if (! $booleanAnd->right instanceof Identical) {
+                    return null;
+                }
+
+                $identical = $booleanAnd->right;
+
+                if ($identical->left instanceof FuncCall
+                    && $this->isName($identical->left->name, 'json_last_error')
+                    && $identical->right instanceof ConstFetch
+                    && $this->isName($identical->right->name, 'JSON_ERROR_NONE')) {
+
+                    return $notIdentical->left; // return json_decode(...) call
+                }
+            }
+
+        }
+
+        return null;
+    }
+}

src/ValueObject/PhpVersionFeature.php

@@ -522,6 +522,11 @@ final class PhpVersionFeature
      */
     public const STR_CONTAINS = PhpVersion::PHP_80;
 
+    /**
+     * @var int
+     */
+    public const JSON_VALIDATE = PhpVersion::PHP_80;
+
     /**
      * @var int
      */
@@ -798,4 +803,10 @@ final class PhpVersionFeature
      * @var int
      */
     public const DEPRECATE_NULL_ARG_IN_ARRAY_KEY_EXISTS_FUNCTION = PhpVersion::PHP_85;
+
+    /**
+     * @see https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_passing_string_which_are_not_one_byte_long_to_ord
+     * @var int
+     */
+    public const DEPRECATE_ORD_WITH_MULTIBYTE_STRING = PhpVersion::PHP_85;
 }