Skip to content

[TypeDeclarationDocblocks] Skip mixed|mixed[] on ClassMethodArrayDocblockParamFromLocalCallsRector#7338

Merged
samsonasik merged 7 commits intomainfrom
skip-mixed-array
Sep 26, 2025
Merged

[TypeDeclarationDocblocks] Skip mixed|mixed[] on ClassMethodArrayDocblockParamFromLocalCallsRector#7338
samsonasik merged 7 commits intomainfrom
skip-mixed-array

Conversation

@samsonasik
Copy link
Copy Markdown
Member

It currently cause

+    /**
+     * @param mixed|mixed[] $argv
+     */

https://getrector.com/demo/e3b82d99-3b41-41ef-a4c1-b77c18506e0e

which should be skipped.

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Copy Markdown
Member Author

I will check if there is better solution to verify ...

@samsonasik samsonasik marked this pull request as draft September 26, 2025 17:55
@samsonasik samsonasik marked this pull request as ready for review September 26, 2025 18:09
@samsonasik
Copy link
Copy Markdown
Member Author

Fixed.

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik enabled auto-merge (squash) September 26, 2025 18:11
@samsonasik samsonasik merged commit 1bdae03 into main Sep 26, 2025
50 checks passed
@samsonasik samsonasik deleted the skip-mixed-array branch September 26, 2025 18:11
}
}
}
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool approach 👏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants