Different logic: verify equal before substr on ClassLikeNameClassNameImportSkipVoter

rector.php

@@ -4,7 +4,6 @@
 
 use Rector\CodingStyle\Rector\String_\UseClassKeywordForClassNameResolutionRector;
 use Rector\Config\RectorConfig;
-use Rector\DeadCode\Rector\Cast\RecastingRemovalRector;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 
@@ -53,9 +52,4 @@
             __DIR__ . '/src/Configuration/RectorConfigBuilder.php',
             __DIR__ . '/src/Console/Notifier.php',
         ],
-
-        // on php 7.x, substr() result can return false, so force (string) is needed
-        RecastingRemovalRector::class => [
-            __DIR__ . '/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php',
-        ],
     ]);

rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php

@@ -46,12 +46,13 @@ public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedO
         $namespace = strtolower((string) $namespace);
 
         $shortNameLowered = $fullyQualifiedObjectType->getShortNameLowered();
-
-        $subClassName = substr(
-            $fullyQualifiedObjectType->getClassName(),
-            0,
-            -strlen($fullyQualifiedObjectType->getShortName()) - 1
-        );
+        $subClassName = $fullyQualifiedObjectType->getClassName() === $fullyQualifiedObjectType->getShortName()
+            ? ''
+            : substr(
+                $fullyQualifiedObjectType->getClassName(),
+                0,
+                -strlen($fullyQualifiedObjectType->getShortName()) - 1
+            );
 
         $fullyQualifiedObjectTypeNamespace = strtolower($subClassName);