Bump nikic/php-parser to ^5.6.2 and Fix AttributeGroupNewLiner for already has new line#7531
Merged
samsonasik merged 5 commits intomainfrom Oct 22, 2025
Merged
Bump nikic/php-parser to ^5.6.2 and Fix AttributeGroupNewLiner for already has new line#7531samsonasik merged 5 commits intomainfrom
samsonasik merged 5 commits intomainfrom
Conversation
…ready has new line
samsonasik
referenced
this pull request
in nikic/PHP-Parser
Oct 22, 2025
With the introduction of attributes, the visibility modifier isn't always at the start of the node anymore. As such, preserve any leaving whitespace. Fixes #1117.
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
|
Ideally we should remove it from places it's not needed anymore, to improve performance on already correct items. Can you check all places we use the new liner service and remove it where no effect? |
Member
Author
|
I will try |
This was referenced Oct 22, 2025
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nikic/php-parser 5.6.2, new line after attribute already detected, so before add new line, verify if new line exists first.
Ref #7530 (comment)