Skip to content

[perf] [experiment] preload all node classes once at start#7638

Closed
TomasVotruba wants to merge 7 commits intomainfrom
tv-parent-node-traverser-2
Closed

[perf] [experiment] preload all node classes once at start#7638
TomasVotruba wants to merge 7 commits intomainfrom
tv-parent-node-traverser-2

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Nov 19, 2025

Follow up to #7634

Todo

  • test this on real projects first, if it actually does perform better than current approach

Related resources

@TomasVotruba TomasVotruba marked this pull request as draft November 19, 2025 10:52
@TomasVotruba TomasVotruba force-pushed the tv-parent-node-traverser-2 branch from 1080e42 to 241920f Compare November 19, 2025 12:14
@TomasVotruba TomasVotruba force-pushed the tv-parent-node-traverser-2 branch from 862d98e to 500bcd0 Compare November 19, 2025 12:27
@TomasVotruba
Copy link
Copy Markdown
Member Author

Before this patch

vendor/bin/rector p src -n --clear-cache  2808.18s user 56.86s system 1613% cpu 2:57.59 total

After this patch

vendor/bin/rector p src -n --clear-cache  2741.56s user 82.17s system 1579% cpu 2:58.79 total

Times are oscilating around similar values on multiple runs, nothing relevant to apply the change.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants