Skip to content

[EarlyReturn] Handle If, elseIf, else all returned on RemoveAlwaysElseRector#7659

Merged
TomasVotruba merged 2 commits intomainfrom
ifelseifelse
Nov 22, 2025
Merged

[EarlyReturn] Handle If, elseIf, else all returned on RemoveAlwaysElseRector#7659
TomasVotruba merged 2 commits intomainfrom
ifelseifelse

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik marked this pull request as draft November 22, 2025 14:20
@samsonasik samsonasik marked this pull request as ready for review November 22, 2025 14:43
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Nov 22, 2025

Fixed 🎉 /cc @u01jmg3 , the space removal inside if is unrelated with it, as expected of php-parser known drawback :)

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready 👍

@TomasVotruba TomasVotruba merged commit 3cf1f51 into main Nov 22, 2025
54 checks passed
@TomasVotruba TomasVotruba deleted the ifelseifelse branch November 22, 2025 15:10
@TomasVotruba
Copy link
Copy Markdown
Member

👌

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RemoveAlwaysElseRector is not fully refactoring code

2 participants