Skip to content

[CodeQuality] Skip with HTML on CompleteMissingIfElseBracketRector#7952

Merged
TomasVotruba merged 2 commits intomainfrom
skip-with-html-bracket
Apr 4, 2026
Merged

[CodeQuality] Skip with HTML on CompleteMissingIfElseBracketRector#7952
TomasVotruba merged 2 commits intomainfrom
skip-with-html-bracket

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Apr 4, 2026

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @sreichel

@samsonasik samsonasik requested a review from TomasVotruba April 4, 2026 05:39
@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

@sreichel
Copy link
Copy Markdown
Contributor

sreichel commented Apr 4, 2026

Thanks.

@TomasVotruba TomasVotruba merged commit 4fb2a68 into main Apr 4, 2026
60 checks passed
@TomasVotruba TomasVotruba deleted the skip-with-html-bracket branch April 4, 2026 07:33
@TomasVotruba
Copy link
Copy Markdown
Member

Thank you 👍

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Apr 4, 2026

@TomasVotruba rector 2.4.0 seems not use latest commit which need pull latest main branch first

rectorphp/rector@a51dfdd

probably need immediate 2.4.1 from latest main branch?

@sreichel
Copy link
Copy Markdown
Contributor

sreichel commented Apr 4, 2026

probably need immediate 2.4.1 from latest main branch?

If you need to release 2.4.1, pls add rectorphp/rector#9728 ... (hope its as easy to fix as prev)

@TomasVotruba
Copy link
Copy Markdown
Member

@samsonasik No rush. We'll include it in the next release, ETA ~2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of CompleteMissingIfElseBracketRector (Syntax error) Incorrect behavior of CompleteMissingIfElseBracketRector (inline braces)

4 participants