Fix LogicalToBooleanRector: parenthesize assignments nested under unary/binary operators#8184
Open
TomasVotruba wants to merge 1 commit into
Open
Fix LogicalToBooleanRector: parenthesize assignments nested under unary/binary operators#8184TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…s nested under unary/binary operators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9807 and #9808.
LogicalToBooleanRectorswapsand/or(low precedence) for&&/||(high precedence). An assignment operand must then be wrapped in parentheses to keep the original semantics. This worked for a direct assignment operand, but not when the assignment was nested one level down — under a unary operator (!,~,+,-,@, casts) or as an operand of a binary operator when it was a compound assignment (+=,-=, …). The result changed runtime behaviour, and~$x = ...even produced a fatalTypeError.Before / after
All reported forms now print correctly:
Fix
In
BetterStandardPrinter::wrapBinaryOpWithBrackets():AssignOpandAssignRef(wasAssignonly), fixing the compound-assignment case (#9808);Covered by 4 new fixtures. Existing printer + LogicalToBooleanRector tests stay green.