[twig] add explicit attribute name arg, to improve context (#907)

TomasVotruba · web-flow · commit 0015fbf8f1be · 2025-12-16T13:46:37.000Z
* add explicit attribute name arg, to improve context

* tidy up
diff --git a/rector.php b/rector.php
@@ -23,7 +23,10 @@
         '*/Source/*',
         '*/Source*/*',
         '*/tests/*/Fixture*/Expected/*',
-        StringClassNameToClassConstantRector::class => [__DIR__ . '/config', __DIR__ . '/src/Enum'],
+        StringClassNameToClassConstantRector::class => [
+            __DIR__ . '/config', __DIR__ . '/src/Enum',
+            __DIR__ . '/rules/CodeQuality/Enum/',
+        ],
         UseClassKeywordForClassNameResolutionRector::class => [__DIR__ . '/config'],
 
         RenameForeachValueVariableToMatchMethodCallReturnTypeRector::class => [
@@ -34,19 +37,8 @@
         // marked as skipped
         ReturnNeverTypeRector::class => ['*/tests/*'],
     ])
-    ->withConfiguredRule(StringClassNameToClassConstantRector::class, [
-        'Error',
-        'Exception',
-        'Symfony\*',
-        'Twig_*',
-        'Twig*',
-        'Swift_*',
-        'Doctrine\*',
-        // loaded from project itself
-        'Psr\Container\ContainerInterface',
-        'Symfony\Component\Routing\RouterInterface',
-        'Symfony\Component\DependencyInjection\Container',
-    ])
+    // @todo cleanup rest and move to enum classes ass single place for class names
+    ->withConfiguredRule(StringClassNameToClassConstantRector::class, ['Symfony\*', 'Twig_*', 'Twig*'])
     ->withPhpSets()
     ->withPreparedSets(
         deadCode: true,
diff --git a/rules-tests/Symfony73/Rector/Class_/GetFiltersToAsTwigFilterAttributeRector/Fixture/some_get_filters.php.inc b/rules-tests/Symfony73/Rector/Class_/GetFiltersToAsTwigFilterAttributeRector/Fixture/some_get_filters.php.inc
@@ -29,7 +29,7 @@ use Twig\Extension\AbstractExtension;
 
 final class SomeGetFilter
 {
-    #[\Twig\Attribute\AsTwigFilter('some_filter')]
+    #[\Twig\Attribute\AsTwigFilter(name: 'some_filter')]
     public function someFilter($value)
     {
         return $value;
diff --git a/rules-tests/Symfony73/Rector/Class_/GetFiltersToAsTwigFilterAttributeRector/Fixture/with_first_class_callable_filter.php.inc b/rules-tests/Symfony73/Rector/Class_/GetFiltersToAsTwigFilterAttributeRector/Fixture/with_first_class_callable_filter.php.inc
@@ -41,19 +41,19 @@ use Twig\Extension\AbstractExtension;
 
 final class WithFirstClassCallableFilter
 {
-    #[\Twig\Attribute\AsTwigFilter('some_filter')]
+    #[\Twig\Attribute\AsTwigFilter(name: 'some_filter')]
     public function someFilter($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('another_filter')]
+    #[\Twig\Attribute\AsTwigFilter(name: 'another_filter')]
     public function anotherFilter($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('third_filter')]
+    #[\Twig\Attribute\AsTwigFilter(name: 'third_filter')]
     public function thirdFilter($value)
     {
         return $value;
diff --git a/rules-tests/Symfony73/Rector/Class_/GetFiltersToAsTwigFilterAttributeRector/Fixture/with_options_argument.php.inc b/rules-tests/Symfony73/Rector/Class_/GetFiltersToAsTwigFilterAttributeRector/Fixture/with_options_argument.php.inc
@@ -82,49 +82,49 @@ use Twig\Extension\AbstractExtension;
 
 final class WithOptionsParameter
 {
-    #[\Twig\Attribute\AsTwigFilter('with_environment', needsEnvironment: true)]
+    #[\Twig\Attribute\AsTwigFilter(name: 'with_environment', needsEnvironment: true)]
     public function withEnvironment(Environment $env, $value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('with_context', needsContext: true)]
+    #[\Twig\Attribute\AsTwigFilter(name: 'with_context', needsContext: true)]
     public function withContext(array $context, $value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('with_charset', needsCharset: true)]
+    #[\Twig\Attribute\AsTwigFilter(name: 'with_charset', needsCharset: true)]
     public function withCharset(string $charset, $value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('with_pre_escape', preEscape: 'html')]
+    #[\Twig\Attribute\AsTwigFilter(name: 'with_pre_escape', preEscape: 'html')]
     public function withPreEscape($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('with_preserves_safety', preservesSafety: ['html'])]
+    #[\Twig\Attribute\AsTwigFilter(name: 'with_preserves_safety', preservesSafety: ['html'])]
     public function withPreservesSafety($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('with_safe_callback', isSafeCallback: [self::class, 'checkSafeCallback'])]
+    #[\Twig\Attribute\AsTwigFilter(name: 'with_safe_callback', isSafeCallback: [self::class, 'checkSafeCallback'])]
     public function withSafeCallback($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('with_deprecation_info', deprecationInfo: new DeprecatedCallableInfo('package', 'version'))]
+    #[\Twig\Attribute\AsTwigFilter(name: 'with_deprecation_info', deprecationInfo: new DeprecatedCallableInfo('package', 'version'))]
     public function withDeprecationInfo($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFilter('with_everything', isSafe: ['html'], needsContext: true, needsCharset: true, needsEnvironment: true, preEscape: 'html', preservesSafety: ['html'])]
+    #[\Twig\Attribute\AsTwigFilter(name: 'with_everything', isSafe: ['html'], needsContext: true, needsCharset: true, needsEnvironment: true, preEscape: 'html', preservesSafety: ['html'])]
     public function withEverything(string $charset, Environment $env, array $context, $value)
     {
         return $value;
diff --git a/rules-tests/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector/Fixture/some_get_functions.php.inc b/rules-tests/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector/Fixture/some_get_functions.php.inc
@@ -41,19 +41,19 @@ use Twig\Extension\AbstractExtension;
 
 final class SomeGetFunctions
 {
-    #[\Twig\Attribute\AsTwigFunction('some_function')]
+    #[\Twig\Attribute\AsTwigFunction(name: 'some_function')]
     public function someFunction($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFunction('another_function')]
+    #[\Twig\Attribute\AsTwigFunction(name: 'another_function')]
     public function anotherFunction($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFunction('third_function')]
+    #[\Twig\Attribute\AsTwigFunction(name: 'third_function')]
     public function thirdFunction($value)
     {
         return $value;
diff --git a/rules-tests/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector/Fixture/with_options_argument.php.inc b/rules-tests/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector/Fixture/with_options_argument.php.inc
@@ -70,37 +70,37 @@ use Twig\Extension\AbstractExtension;
 
 final class WithOptionsParameter
 {
-    #[\Twig\Attribute\AsTwigFunction('with_environment', needsEnvironment: true)]
+    #[\Twig\Attribute\AsTwigFunction(name: 'with_environment', needsEnvironment: true)]
     public function withEnvironment(Environment $env, $value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFunction('with_context', needsContext: true)]
+    #[\Twig\Attribute\AsTwigFunction(name: 'with_context', needsContext: true)]
     public function withContext(array $context, $value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFunction('with_charset', needsCharset: true)]
+    #[\Twig\Attribute\AsTwigFunction(name: 'with_charset', needsCharset: true)]
     public function withCharset(string $charset, $value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFunction('with_safe_callback', isSafeCallback: [self::class, 'checkSafeCallback'])]
+    #[\Twig\Attribute\AsTwigFunction(name: 'with_safe_callback', isSafeCallback: [self::class, 'checkSafeCallback'])]
     public function withSafeCallback($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFunction('with_deprecation_info', deprecationInfo: new DeprecatedCallableInfo('package', 'version'))]
+    #[\Twig\Attribute\AsTwigFunction(name: 'with_deprecation_info', deprecationInfo: new DeprecatedCallableInfo('package', 'version'))]
     public function withDeprecationInfo($value)
     {
         return $value;
     }
 
-    #[\Twig\Attribute\AsTwigFunction('with_everything', isSafe: ['html'], needsContext: true, needsCharset: true, needsEnvironment: true)]
+    #[\Twig\Attribute\AsTwigFunction(name: 'with_everything', isSafe: ['html'], needsContext: true, needsCharset: true, needsEnvironment: true)]
     public function withEverything(string $charset, Environment $env, array $context, $value)
     {
         return $value;
diff --git a/rules/CodeQuality/Rector/ClassMethod/RemoveUnusedRequestParamRector.php b/rules/CodeQuality/Rector/ClassMethod/RemoveUnusedRequestParamRector.php
@@ -17,6 +17,7 @@
 use Rector\Rector\AbstractRector;
 use Rector\Reflection\ReflectionResolver;
 use Rector\Symfony\TypeAnalyzer\ControllerAnalyzer;
+use Symplify\PHPStanRules\Enum\SymfonyClass;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -110,7 +111,7 @@ public function refactor(Node $node): ?Node
                     continue;
                 }
 
-                if (! $this->isObjectType($param->type, new ObjectType('Symfony\Component\HttpFoundation\Request'))) {
+                if (! $this->isObjectType($param->type, new ObjectType(SymfonyClass::REQUEST))) {
                     continue;
                 }
 
diff --git a/rules/CodeQuality/Rector/ClassMethod/ResponseReturnTypeControllerActionRector.php b/rules/CodeQuality/Rector/ClassMethod/ResponseReturnTypeControllerActionRector.php
@@ -25,6 +25,7 @@
 use Rector\Symfony\CodeQuality\Enum\ResponseClass;
 use Rector\Symfony\Enum\SensioAttribute;
 use Rector\Symfony\Enum\SymfonyAnnotation;
+use Rector\Symfony\Enum\SymfonyClass;
 use Rector\Symfony\TypeAnalyzer\ControllerAnalyzer;
 use Rector\TypeDeclaration\NodeAnalyzer\ReturnAnalyzer;
 use Rector\TypeDeclaration\TypeInferer\ReturnTypeInferer;
@@ -125,7 +126,8 @@ public function refactor(Node $node): ?Node
 
             $returnType = $this->returnTypeInferer->inferFunctionLike($node);
             $types = $returnType instanceof UnionType ? $returnType->getTypes() : [$returnType];
-            $objectType = new ObjectType('Symfony\Component\HttpFoundation\Response');
+
+            $objectType = new ObjectType(SymfonyClass::RESPONSE);
 
             foreach ($types as $type) {
                 if ($type instanceof ObjectType && $objectType->isSuperTypeOf($type)->yes()) {
diff --git a/rules/Symfony30/Rector/ClassMethod/GetRequestRector.php b/rules/Symfony30/Rector/ClassMethod/GetRequestRector.php
@@ -16,6 +16,7 @@
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
 use Rector\Symfony\Bridge\NodeAnalyzer\ControllerMethodAnalyzer;
+use Rector\Symfony\Enum\SymfonyClass;
 use Rector\Symfony\TypeAnalyzer\ControllerAnalyzer;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -25,11 +26,6 @@
  */
 final class GetRequestRector extends AbstractRector
 {
-    /**
-     * @var string
-     */
-    private const REQUEST_CLASS = 'Symfony\Component\HttpFoundation\Request';
-
     private ?string $requestVariableAndParamName = null;
 
     public function __construct(
@@ -230,7 +226,7 @@ private function refactorClassMethod(ClassMethod $classMethod): null|ClassMethod
             return null;
         }
 
-        $fullyQualified = new FullyQualified(self::REQUEST_CLASS);
+        $fullyQualified = new FullyQualified(SymfonyClass::REQUEST);
         $classMethod->params[] = new Param(new Variable(
             $this->getRequestVariableAndParamName()
         ), null, $fullyQualified);
diff --git a/rules/Symfony51/Rector/ClassMethod/CommandConstantReturnCodeRector.php b/rules/Symfony51/Rector/ClassMethod/CommandConstantReturnCodeRector.php
@@ -13,6 +13,7 @@
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
 use Rector\Reflection\ReflectionResolver;
+use Rector\Symfony\Enum\SymfonyClass;
 use Rector\Symfony\ValueObject\ConstantMap\SymfonyCommandConstantMap;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -80,7 +81,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if (! $classReflection->is('Symfony\Component\Console\Command\Command')) {
+        if (! $classReflection->is(SymfonyClass::COMMAND)) {
             return null;
         }
 
@@ -121,7 +122,7 @@ private function convertNumberToConstant(Int_ $int): ?ClassConstFetch
         }
 
         return $this->nodeFactory->createClassConstFetch(
-            'Symfony\Component\Console\Command\Command',
+            SymfonyClass::COMMAND,
             SymfonyCommandConstantMap::RETURN_TO_CONST[$int->value]
         );
     }
diff --git a/rules/Symfony61/Rector/Class_/MagicClosureTwigExtensionToNativeMethodsRector.php b/rules/Symfony61/Rector/Class_/MagicClosureTwigExtensionToNativeMethodsRector.php
@@ -16,6 +16,7 @@
 use Rector\NodeCollector\ValueObject\ArrayCallable;
 use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
+use Rector\Symfony\Enum\TwigClass;
 use Rector\ValueObject\PhpVersion;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -100,7 +101,7 @@ public function refactor(Node $node): ?Node
     {
         if (! $this->nodeTypeResolver->isObjectTypes($node, [
             new ObjectType('Twig_ExtensionInterface'),
-            new ObjectType('Twig\Extension\ExtensionInterface'),
+            new ObjectType(TwigClass::EXTENSION_INTERFACE),
         ])) {
             return null;
         }
diff --git a/rules/Symfony73/GetMethodToAsTwigAttributeTransformer.php b/rules/Symfony73/GetMethodToAsTwigAttributeTransformer.php
@@ -127,6 +127,8 @@ public function transformClassGetMethodToAttributeMarker(
                     // remove old new function instance
                     unset($returnArray->items[$key]);
 
+                    $nameArg->name = new Identifier('name');
+
                     $hasChanged = true;
                 }
             }
diff --git a/rules/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector.php b/rules/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector.php
@@ -52,13 +52,12 @@ public function localMethod(Environment $env, $value)
 CODE_SAMPLE
                     ,
                     <<<'CODE_SAMPLE'
-use Twig\Extension\AbstractExtension;
 use Twig\Attribute\AsTwigFunction;
 use Twig\Environment;
 
-class SomeClass extends AbstractExtension
+class SomeClass
 {
-    #[AsTwigFunction('function_name', needsEnvironment: true)]
+    #[AsTwigFunction(name: 'function_name', needsEnvironment: true)]
     public function localMethod(Environment $env, $value)
     {
         return $value;
diff --git a/src/Bridge/Symfony/ContainerServiceProvider.php b/src/Bridge/Symfony/ContainerServiceProvider.php
@@ -7,6 +7,7 @@
 use Rector\Configuration\Option;
 use Rector\Configuration\Parameter\SimpleParameterProvider;
 use Rector\Exception\ShouldNotHappenException;
+use Rector\Symfony\Enum\SymfonyClass;
 use Symfony\Component\DependencyInjection\Container;
 use Webmozart\Assert\Assert;
 
@@ -37,7 +38,7 @@ private function getSymfonyContainer(): object
             $container = require $symfonyContainerPhp;
 
             // this allows older Symfony versions, e.g. 2.8 did not have the PSR yet
-            Assert::isInstanceOf($container, 'Symfony\Component\DependencyInjection\Container');
+            Assert::isInstanceOf($container, SymfonyClass::CONTAINER);
             $this->container = $container;
         }
 
diff --git a/src/Enum/SymfonyClass.php b/src/Enum/SymfonyClass.php
@@ -226,4 +226,6 @@ final class SymfonyClass
     public const ROUTING_CONFIGURATOR = 'Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator';
 
     public const KERNEL = 'Symfony\Component\HttpKernel\Kernel';
+
+    public const CONTAINER = 'Symfony\Component\DependencyInjection\Container';
 }
diff --git a/src/Enum/TwigClass.php b/src/Enum/TwigClass.php
@@ -20,4 +20,9 @@ final class TwigClass
      * @var string
      */
     public const AS_TWIG_FUNCTION_ATTRIBUTE = 'Twig\Attribute\AsTwigFunction';
+
+    /**
+     * @var string
+     */
+    public const EXTENSION_INTERFACE = 'Twig\Extension\ExtensionInterface';
 }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ use Twig\Extension\AbstractExtension;`
`29`	`29`
`30`	`30`	`final class SomeGetFilter`
`31`	`31`	`{`
`32`		`- #[\Twig\Attribute\AsTwigFilter('some_filter')]`
	`32`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'some_filter')]`
`33`	`33`	`public function someFilter($value)`
`34`	`34`	`{`
`35`	`35`	`return $value;`
Original file line number	Diff line number	Diff line change
`@@ -41,19 +41,19 @@ use Twig\Extension\AbstractExtension;`
`41`	`41`
`42`	`42`	`final class WithFirstClassCallableFilter`
`43`	`43`	`{`
`44`		`- #[\Twig\Attribute\AsTwigFilter('some_filter')]`
	`44`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'some_filter')]`
`45`	`45`	`public function someFilter($value)`
`46`	`46`	`{`
`47`	`47`	`return $value;`
`48`	`48`	`}`
`49`	`49`
`50`		`- #[\Twig\Attribute\AsTwigFilter('another_filter')]`
	`50`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'another_filter')]`
`51`	`51`	`public function anotherFilter($value)`
`52`	`52`	`{`
`53`	`53`	`return $value;`
`54`	`54`	`}`
`55`	`55`
`56`		`- #[\Twig\Attribute\AsTwigFilter('third_filter')]`
	`56`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'third_filter')]`
`57`	`57`	`public function thirdFilter($value)`
`58`	`58`	`{`
`59`	`59`	`return $value;`
Original file line number	Diff line number	Diff line change
`@@ -82,49 +82,49 @@ use Twig\Extension\AbstractExtension;`
`82`	`82`
`83`	`83`	`final class WithOptionsParameter`
`84`	`84`	`{`
`85`		`- #[\Twig\Attribute\AsTwigFilter('with_environment', needsEnvironment: true)]`
	`85`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'with_environment', needsEnvironment: true)]`
`86`	`86`	`public function withEnvironment(Environment $env, $value)`
`87`	`87`	`{`
`88`	`88`	`return $value;`
`89`	`89`	`}`
`90`	`90`
`91`		`- #[\Twig\Attribute\AsTwigFilter('with_context', needsContext: true)]`
	`91`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'with_context', needsContext: true)]`
`92`	`92`	`public function withContext(array $context, $value)`
`93`	`93`	`{`
`94`	`94`	`return $value;`
`95`	`95`	`}`
`96`	`96`
`97`		`- #[\Twig\Attribute\AsTwigFilter('with_charset', needsCharset: true)]`
	`97`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'with_charset', needsCharset: true)]`
`98`	`98`	`public function withCharset(string $charset, $value)`
`99`	`99`	`{`
`100`	`100`	`return $value;`
`101`	`101`	`}`
`102`	`102`
`103`		`- #[\Twig\Attribute\AsTwigFilter('with_pre_escape', preEscape: 'html')]`
	`103`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'with_pre_escape', preEscape: 'html')]`
`104`	`104`	`public function withPreEscape($value)`
`105`	`105`	`{`
`106`	`106`	`return $value;`
`107`	`107`	`}`
`108`	`108`
`109`		`- #[\Twig\Attribute\AsTwigFilter('with_preserves_safety', preservesSafety: ['html'])]`
	`109`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'with_preserves_safety', preservesSafety: ['html'])]`
`110`	`110`	`public function withPreservesSafety($value)`
`111`	`111`	`{`
`112`	`112`	`return $value;`
`113`	`113`	`}`
`114`	`114`
`115`		`- #[\Twig\Attribute\AsTwigFilter('with_safe_callback', isSafeCallback: [self::class, 'checkSafeCallback'])]`
	`115`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'with_safe_callback', isSafeCallback: [self::class, 'checkSafeCallback'])]`
`116`	`116`	`public function withSafeCallback($value)`
`117`	`117`	`{`
`118`	`118`	`return $value;`
`119`	`119`	`}`
`120`	`120`
`121`		`- #[\Twig\Attribute\AsTwigFilter('with_deprecation_info', deprecationInfo: new DeprecatedCallableInfo('package', 'version'))]`
	`121`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'with_deprecation_info', deprecationInfo: new DeprecatedCallableInfo('package', 'version'))]`
`122`	`122`	`public function withDeprecationInfo($value)`
`123`	`123`	`{`
`124`	`124`	`return $value;`
`125`	`125`	`}`
`126`	`126`
`127`		`- #[\Twig\Attribute\AsTwigFilter('with_everything', isSafe: ['html'], needsContext: true, needsCharset: true, needsEnvironment: true, preEscape: 'html', preservesSafety: ['html'])]`
	`127`	`+ #[\Twig\Attribute\AsTwigFilter(name: 'with_everything', isSafe: ['html'], needsContext: true, needsCharset: true, needsEnvironment: true, preEscape: 'html', preservesSafety: ['html'])]`
`128`	`128`	`public function withEverything(string $charset, Environment $env, array $context, $value)`
`129`	`129`	`{`
`130`	`130`	`return $value;`
Original file line number	Diff line number	Diff line change
`@@ -70,37 +70,37 @@ use Twig\Extension\AbstractExtension;`
`70`	`70`
`71`	`71`	`final class WithOptionsParameter`
`72`	`72`	`{`
`73`		`- #[\Twig\Attribute\AsTwigFunction('with_environment', needsEnvironment: true)]`
	`73`	`+ #[\Twig\Attribute\AsTwigFunction(name: 'with_environment', needsEnvironment: true)]`
`74`	`74`	`public function withEnvironment(Environment $env, $value)`
`75`	`75`	`{`
`76`	`76`	`return $value;`
`77`	`77`	`}`
`78`	`78`
`79`		`- #[\Twig\Attribute\AsTwigFunction('with_context', needsContext: true)]`
	`79`	`+ #[\Twig\Attribute\AsTwigFunction(name: 'with_context', needsContext: true)]`
`80`	`80`	`public function withContext(array $context, $value)`
`81`	`81`	`{`
`82`	`82`	`return $value;`
`83`	`83`	`}`
`84`	`84`
`85`		`- #[\Twig\Attribute\AsTwigFunction('with_charset', needsCharset: true)]`
	`85`	`+ #[\Twig\Attribute\AsTwigFunction(name: 'with_charset', needsCharset: true)]`
`86`	`86`	`public function withCharset(string $charset, $value)`
`87`	`87`	`{`
`88`	`88`	`return $value;`
`89`	`89`	`}`
`90`	`90`
`91`		`- #[\Twig\Attribute\AsTwigFunction('with_safe_callback', isSafeCallback: [self::class, 'checkSafeCallback'])]`
	`91`	`+ #[\Twig\Attribute\AsTwigFunction(name: 'with_safe_callback', isSafeCallback: [self::class, 'checkSafeCallback'])]`
`92`	`92`	`public function withSafeCallback($value)`
`93`	`93`	`{`
`94`	`94`	`return $value;`
`95`	`95`	`}`
`96`	`96`
`97`		`- #[\Twig\Attribute\AsTwigFunction('with_deprecation_info', deprecationInfo: new DeprecatedCallableInfo('package', 'version'))]`
	`97`	`+ #[\Twig\Attribute\AsTwigFunction(name: 'with_deprecation_info', deprecationInfo: new DeprecatedCallableInfo('package', 'version'))]`
`98`	`98`	`public function withDeprecationInfo($value)`
`99`	`99`	`{`
`100`	`100`	`return $value;`
`101`	`101`	`}`
`102`	`102`
`103`		`- #[\Twig\Attribute\AsTwigFunction('with_everything', isSafe: ['html'], needsContext: true, needsCharset: true, needsEnvironment: true)]`
	`103`	`+ #[\Twig\Attribute\AsTwigFunction(name: 'with_everything', isSafe: ['html'], needsContext: true, needsCharset: true, needsEnvironment: true)]`
`104`	`104`	`public function withEverything(string $charset, Environment $env, array $context, $value)`
`105`	`105`	`{`
`106`	`106`	`return $value;`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`use Rector\Rector\AbstractRector;`
`18`	`18`	`use Rector\Reflection\ReflectionResolver;`
`19`	`19`	`use Rector\Symfony\TypeAnalyzer\ControllerAnalyzer;`
	`20`	`+use Symplify\PHPStanRules\Enum\SymfonyClass;`
`20`	`21`	`use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;`
`21`	`22`	`use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;`
`22`	`23`
`@@ -110,7 +111,7 @@ public function refactor(Node $node): ?Node`
`110`	`111`	`continue;`
`111`	`112`	`}`
`112`	`113`
`113`		`- if (! $this->isObjectType($param->type, new ObjectType('Symfony\Component\HttpFoundation\Request'))) {`
	`114`	`+ if (! $this->isObjectType($param->type, new ObjectType(SymfonyClass::REQUEST))) {`
`114`	`115`	`continue;`
`115`	`116`	`}`
`116`	`117`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`use Rector\PhpParser\Node\BetterNodeFinder;`
`14`	`14`	`use Rector\Rector\AbstractRector;`
`15`	`15`	`use Rector\Reflection\ReflectionResolver;`
	`16`	`+use Rector\Symfony\Enum\SymfonyClass;`
`16`	`17`	`use Rector\Symfony\ValueObject\ConstantMap\SymfonyCommandConstantMap;`
`17`	`18`	`use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;`
`18`	`19`	`use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;`
`@@ -80,7 +81,7 @@ public function refactor(Node $node): ?Node`
`80`	`81`	`return null;`
`81`	`82`	`}`
`82`	`83`
`83`		`- if (! $classReflection->is('Symfony\Component\Console\Command\Command')) {`
	`84`	`+ if (! $classReflection->is(SymfonyClass::COMMAND)) {`
`84`	`85`	`return null;`
`85`	`86`	`}`
`86`	`87`
`@@ -121,7 +122,7 @@ private function convertNumberToConstant(Int_ $int): ?ClassConstFetch`
`121`	`122`	`}`
`122`	`123`
`123`	`124`	`return $this->nodeFactory->createClassConstFetch(`
`124`		`- 'Symfony\Component\Console\Command\Command',`
	`125`	`+ SymfonyClass::COMMAND,`
`125`	`126`	`SymfonyCommandConstantMap::RETURN_TO_CONST[$int->value]`
`126`	`127`	`);`
`127`	`128`	`}`