[CodeQuality] Skip from route path /edit/{id} on ControllerMethodInjectionToConstructorRector (#877)

* [CodeQuality] Skip from route path /edit/{id} on ControllerMethodInjectionToConstructorRector

* Fix

* Fix

Author: samsonasik

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Fixture/skip_from_route_path.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class SkipFromRoutePath extends AbstractController
+{
+    #[Route(path: '/edit/{id}', name: 'edit')]
+    public function someAction(Request $request, ?string $id = null)
+    {
+    }
+}

rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php

@@ -9,7 +9,7 @@
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
-use PhpParser\Node\Name;
+use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use Rector\Doctrine\NodeAnalyzer\AttributeFinder;
@@ -117,19 +117,17 @@ public function refactor(Node $node): ?Node
 
             foreach ($classMethod->getParams() as $key => $param) {
                 // skip scalar and empty values, as not services
-                if ($param->type === null || $param->type instanceof Identifier) {
+                if ($param->type === null || ! $param->type instanceof FullyQualified) {
                     continue;
                 }
 
                 // request is allowed
-                if ($param->type instanceof Name) {
-                    if ($this->isName($param->type, SymfonyClass::REQUEST)) {
-                        continue;
-                    }
+                if ($this->isName($param->type, SymfonyClass::REQUEST)) {
+                    continue;
+                }
 
-                    if ($this->isNames($param->type, $entityClasses)) {
-                        continue;
-                    }
+                if ($this->isNames($param->type, $entityClasses)) {
+                    continue;
                 }
 
                 // @todo allow parameter converter