decouple class to strings

Author: TomasVotruba

composer.json

@@ -12,20 +12,21 @@
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "^2.1.31",
         "phpstan/phpstan-webmozart-assert": "^2.0",
-        "phpunit/phpunit": "^11.4",
+        "phpunit/phpunit": "^11.5",
+        "rector/jack": "^0.2.9",
         "rector/rector-src": "dev-main",
-        "rector/type-perfect": "^2.0",
+        "rector/type-perfect": "^2.1",
         "symfony/config": "^6.4",
         "symfony/dependency-injection": "^6.4",
-        "symfony/http-kernel": "^6.4",
+        "symfony/http-kernel": "^7.0",
         "symfony/routing": "^6.4",
         "symfony/security-core": "^6.4",
         "symfony/security-http": "^6.4",
         "symfony/validator": "^6.4",
         "symfony/web-link": "^6.4",
         "symplify/phpstan-extensions": "^12.0",
-        "symplify/phpstan-rules": "^14.6",
-        "symplify/vendor-patches": "^11.3",
+        "symplify/phpstan-rules": "^14.8",
+        "symplify/vendor-patches": "^11.5",
         "tomasvotruba/class-leak": "^2.0",
         "tomasvotruba/type-coverage": "^2.0",
         "tomasvotruba/unused-public": "^2.0",

phpstan.neon

@@ -39,16 +39,10 @@ parameters:
         # pointless check
         - '#expects class-string, string given#'
 
-        - '#Calling PHPStan\\Reflection\\Php\\PhpParameterReflection\:\:getName\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version#'
-
         # false positive
         - '#but class PhpParser\\Node\\Stmt\\Expression is not generic#'
         - '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
 
-        # false positive
-        - '#Parameters should have "PhpParser\\Node\\Expr\\Closure" types as the only types passed to this method#'
-        - '#Parameter 1 should use "PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionMethod" type as the only type passed to this method#'
-
         # more advanced usage, but not always working
         # see https://github.com/rectorphp/rector-src/actions/runs/11798721617/job/32865546672?pr=6422#step:5:110
         - '#Doing instanceof PHPStan\\Type\\.+ is error\-prone and deprecated#'
@@ -59,3 +53,9 @@ parameters:
 
         # avoid notice on run on php 8.3
         - identifier: typeCoverage.constantTypeCoverage
+
+        # false postitive
+        -
+            identifier: typePerfect.narrowPublicClassMethodParamType
+            path: src/NodeAnalyzer/SymfonyPhpClosureDetector.php
+        - '#Parameter 1 should use "PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionMethod" type as the only type passed to this method#'

rules/Symfony62/Rector/ClassMethod/ClassMethod/ArgumentValueResolverToValueResolverRector.php

@@ -17,8 +17,7 @@
 use PhpParser\Node\Stmt\If_;
 use PhpParser\Node\Stmt\Return_;
 use Rector\Rector\AbstractRector;
-use Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface;
-use Symfony\Component\HttpKernel\Controller\ValueResolverInterface;
+use Rector\Symfony\Enum\SymfonyClass;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -63,7 +62,7 @@ public function refactor(Node $node): ?Node
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Replaces ArgumentValueResolverInterface by ValueResolverInterface',
+            'Replaces ArgumentValueResolverInterface by ValueResolverInterface with supports logic moved to resolve() method',
             [
                 new CodeSample(
                     <<<'CODE_SAMPLE'
@@ -100,8 +99,8 @@ private function shouldRefactorClass(Class_ $class): bool
     {
         // Check if the class implements ArgumentValueResolverInterface
         foreach ($class->implements as $key => $interface) {
-            if ($interface->toString() === ArgumentValueResolverInterface::class) {
-                $class->implements[$key] = new FullyQualified(ValueResolverInterface::class);
+            if ($interface->toString() === SymfonyClass::ARGUMENT_RESOLVER_INTERFACE) {
+                $class->implements[$key] = new FullyQualified(SymfonyClass::VALUE_RESOLVER_INTERFACE);
                 return true;
             }
         }

src/Enum/SymfonyClass.php

@@ -170,4 +170,14 @@ final class SymfonyClass
      * @var string
      */
     public const SERVICES_CONFIGURATOR = 'Symfony\Component\DependencyInjection\Loader\Configurator\ServicesConfigurator';
+
+    /**
+     * @var string
+     */
+    public const ARGUMENT_RESOLVER_INTERFACE = 'Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface';
+
+    /**
+     * @var string
+     */
+    public const VALUE_RESOLVER_INTERFACE = 'Symfony\Component\HttpKernel\Controller\ValueResolverInterface';
 }