[CodeQuality] Skip different service same name on ControllerMethodInjectionToConstructorRector (#894)

* [CodeQuality] Skip different service same name on ControllerMethodInjectionToConstructorRector

* Fix

* Fix

Author: samsonasik

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Fixture/skip_different_service_same_name.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+
+final class DemoController extends AbstractController
+{
+    public function __construct(
+        private readonly UpdateAppContext $context // This is not the same service as AdminContext
+    ) {
+    }
+
+    public function __invoke(AdminContext $context): int
+    {
+       return $context->getNumber(); // This is not the same service as UpdateAppContext
+    }
+}

rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php

@@ -118,6 +118,16 @@ public function refactor(Node $node): ?Node
 
         $propertyMetadatas = [];
 
+        $constructParamVariables = [];
+        $constructClassMethod = $node->getMethod(MethodName::CONSTRUCT);
+        if ($constructClassMethod instanceof ClassMethod) {
+            foreach ($constructClassMethod->params as $param) {
+                if ($param->type instanceof FullyQualified) {
+                    $constructParamVariables[$param->type->toString()] = $this->getName($param->var);
+                }
+            }
+        }
+
         foreach ($node->getMethods() as $classMethod) {
             if ($this->shouldSkipClassMethod($classMethod)) {
                 continue;
@@ -152,10 +162,21 @@ public function refactor(Node $node): ?Node
 
                 $paramType = $this->staticTypeMapper->mapPhpParserNodePHPStanType($param->type);
 
-                if ($paramType instanceof ObjectType) {
-                    if ($paramType->isEnum()->yes()) {
-                        continue;
-                    }
+                if (! $paramType instanceof ObjectType) {
+                    continue;
+                }
+
+                if ($paramType->isEnum()->yes()) {
+                    continue;
+                }
+
+                if (
+                    $constructParamVariables !== []
+                    && in_array($this->getName($param->var), $constructParamVariables, true)
+                    &&
+                    ! in_array($this->getName($param->type), array_keys($constructParamVariables), true)
+                ) {
+                    continue;
                 }
 
                 unset($classMethod->params[$key]);