cleanup CI, add finalise and bump to PHP 8.3 (#915)

* add finalise

* bump PHP 8.3

* upgrade syntax to PHP 8.3

* merge reusable to avoid external deps

* remove reference

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -20,17 +20,31 @@ jobs:
                         name: 'Active Classes'
                         run: vendor/bin/class-leak check config src rules --ansi --skip-suffix "Rector" --skip-type "\Rector\Set\Contract\SetProviderInterface"
 
+                    -
+                        name: "Finalize Classes"
+                        run: vendor/bin/swiss-knife finalize config src tests rules rules-tests --ansi
+
+                    -
+                        name: 'Composer Validate'
+                        run: composer validate
+
+                    -
+                        name: 'PHPStan'
+                        run: vendor/bin/phpstan
+
         name: ${{ matrix.actions.name }}
+
         runs-on: ubuntu-latest
-        timeout-minutes: 10
+
+        timeout-minutes: 5
 
         steps:
             -   uses: actions/checkout@v4
 
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.2
+                    php-version: 8.3
                     coverage: none
 
             -   uses: "ramsey/composer-install@v2"

.github/workflows/code_analysis_reusable.yaml

@@ -21,7 +21,7 @@ jobs:
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.2
+                    php-version: 8.3
                     coverage: none
 
             -   uses: "ramsey/composer-install@v2"

.github/workflows/tests.yaml

@@ -4,18 +4,19 @@
     "license": "MIT",
     "description": "Rector upgrades rules for Symfony Framework",
     "require": {
-        "php": ">=8.2",
+        "php": ">=8.3",
         "ext-xml": "*"
     },
     "require-dev": {
-        "phpecs/phpecs": "^2.2",
+        "symplify/easy-coding-standard": "^13.0.4",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "^2.1.32",
         "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpstan/phpstan-webmozart-assert": "^2.0",
         "phpunit/phpunit": "^11.5",
-        "rector/jack": "^0.4",
+        "rector/jack": "^0.5",
         "rector/rector-src": "dev-main",
+        "rector/swiss-knife": "^2.3",
         "rector/type-perfect": "^2.1",
         "symfony/config": "^6.4",
         "symfony/dependency-injection": "^6.4",
@@ -30,7 +31,7 @@
         "symplify/vendor-patches": "^11.5",
         "tomasvotruba/class-leak": "^2.1",
         "tomasvotruba/type-coverage": "^2.1",
-        "tomasvotruba/unused-public": "^2.1",
+        "tomasvotruba/unused-public": "^2.2",
         "tracy/tracy": "^2.11"
     },
     "autoload": {

composer.json

@@ -1,7 +1,6 @@
-# @todo enable
-#includes:
-#    - vendor/symplify/phpstan-rules/config/symplify-rules.neon
-#    - vendor/symplify/phpstan-rules/config/rector-rules.neon
+includes:
+    - vendor/symplify/phpstan-rules/config/symplify-rules.neon
+    - vendor/symplify/phpstan-rules/config/rector-rules.neon
 
 rules:
     - Symplify\PHPStanRules\Rules\StringFileAbsolutePathExistsRule
@@ -14,7 +13,7 @@ parameters:
     typeAliases:
         StmtsAware: \PhpParser\Node\Stmt\Block | \PhpParser\Node\Expr\Closure | \PhpParser\Node\Stmt\Case_ | \PhpParser\Node\Stmt\Catch_ | \PhpParser\Node\Stmt\ClassMethod | \PhpParser\Node\Stmt\Do_ | \PhpParser\Node\Stmt\Else_ | \PhpParser\Node\Stmt\ElseIf_ | \PhpParser\Node\Stmt\Finally_ | \PhpParser\Node\Stmt\For_ | \PhpParser\Node\Stmt\Foreach_ | \PhpParser\Node\Stmt\Function_ | \PhpParser\Node\Stmt\If_ | \PhpParser\Node\Stmt\Namespace_ | \PhpParser\Node\Stmt\TryCatch | \PhpParser\Node\Stmt\While_ | \Rector\PhpParser\Node\FileNode
 
-    reportUnmatchedIgnoredErrors: false
+    # reportUnmatchedIgnoredErrors: false
     treatPhpDocTypesAsCertain: false
 
     paths:
@@ -50,7 +49,6 @@ parameters:
 
         # false positive
         - '#but class PhpParser\\Node\\Stmt\\Expression is not generic#'
-        - '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
 
         # more advanced usage, but not always working
         # see https://github.com/rectorphp/rector-src/actions/runs/11798721617/job/32865546672?pr=6422#step:5:110
@@ -69,13 +67,21 @@ parameters:
 
         - '#Parameter 1 should use "PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionMethod" type as the only type passed to this method#'
 
-        # local use php 8.3
-        - identifier: typeCoverage.constantTypeCoverage
-
         # in tests
         -
             message: '#Fetching deprecated class constant SYMFONY_(.*?) of class Rector\\Symfony\\Set\\SymfonySetList#'
             paths:
                 - tests
                 - config/sets/symfony/annotations-to-attributes.php
 
+        # using XML to load symfony config
+        -
+            path: src/ValueObjectFactory/ServiceMapFactory.php
+            identifier: rector.noInstanceOfStaticReflection
+
+        -
+            path: src/ValueObjectFactory/ServiceMapFactory.php
+            message: '#"@simplexml_load_string\(\$fileContents\)" is forbidden to use#'
+
+
+

phpstan.neon

@@ -37,14 +37,14 @@
         // marked as skipped
         ReturnNeverTypeRector::class => ['*/tests/*'],
     ])
-    // @todo cleanup rest and move to enum classes ass single place for class names
     ->withConfiguredRule(StringClassNameToClassConstantRector::class, ['Symfony\*', 'Twig_*', 'Twig*'])
     ->withPhpSets()
     ->withPreparedSets(
         deadCode: true,
         codeQuality: true,
         codingStyle: true,
         typeDeclarations: true,
+        typeDeclarationDocblocks: true,
         privatization: true,
         naming: true,
         rectorPreset: true,

rector.php

@@ -2,7 +2,7 @@
 
 namespace Rector\Symfony\Tests\CodeQuality\Rector\ClassMethod\ResponseReturnTypeControllerActionRector\Source;
 
-class CustomObject
+final class CustomObject
 {
 
 }

rules-tests/CodeQuality/Rector/ClassMethod/ResponseReturnTypeControllerActionRector/Source/CustomObject.php

@@ -8,7 +8,7 @@
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Routing\Annotation\Route;
 
-class IntermediateController extends AbstractController
+final class IntermediateController extends AbstractController
 {
     #[Route('/some-action', name: 'some_action')]
     public function someAction(LoggerInterface $logger)

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Source/IntermediateController.php

@@ -5,6 +5,6 @@
 namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Source;
 
 #[\Attribute]
-class SomeType
+final class SomeType
 {
 }

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Source/SomeType.php

@@ -6,6 +6,6 @@
 
 use Symfony\Component\Security\Core\User\UserInterface;
 
-class SomeUser implements UserInterface
+final class SomeUser implements UserInterface
 {
 }