[config] Add RemoveConstructorAutowireServiceRector

Author: TomasVotruba

config/sets/symfony/configs.php

@@ -4,6 +4,7 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Symfony\Configs\Rector\Closure\MergeServiceNameTypeRector;
+use Rector\Symfony\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector;
 use Rector\Symfony\Configs\Rector\Closure\ServiceArgsToServiceNamedArgRector;
 use Rector\Symfony\Configs\Rector\Closure\ServiceSetStringNameToClassNameRector;
 use Rector\Symfony\Configs\Rector\Closure\ServiceSettersToSettersAutodiscoveryRector;
@@ -16,5 +17,6 @@
         ServiceSetStringNameToClassNameRector::class,
         ServiceSettersToSettersAutodiscoveryRector::class,
         ServiceTagsToDefaultsAutoconfigureRector::class,
+        RemoveConstructorAutowireServiceRector::class,
     ]);
 };

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/avoid_different_type.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\DifferentType;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set(AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', service(DifferentType::class));
+};

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/skip_no_defaults_autowire.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->set(AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', service(PassedAsDependency::class));
+};

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/skip_no_service_type.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set(AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', 123);
+};

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/some_class.php.inc

@@ -0,0 +1,42 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set(AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', service(PassedAsDependency::class));
+};
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set(AnotherClassWithoutConstructor::class);
+};
+
+?>

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/RemoveConstructorAutowireServiceRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveConstructorAutowireServiceRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Source/AnotherClassWithoutConstructor.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source;
+
+final class AnotherClassWithoutConstructor
+{
+    public function __construct(
+        PassedAsDependency $passedAsDependency
+    ) {
+    }
+}

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Source/DifferentType.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source;
+
+final class DifferentType
+{
+}

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Source/PassedAsDependency.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source;
+
+final class PassedAsDependency
+{
+}

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(RemoveConstructorAutowireServiceRector::class);
+};