add fixture

Author: TomasVotruba

rules-tests/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture/DefaultValue/implicit_no_value_bool_option.php.inc

@@ -0,0 +1,52 @@
+<?php
+
+namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture\DefaultValue;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Output\OutputInterface;
+
+#[AsCommand(
+    name: 'app:hello',
+)]
+class ImplicitNoValueBoolOption extends Command
+{
+    protected function configure(): void
+    {
+        $this->addOption('third', null, InputOption::VALUE_NONE);
+    }
+    protected function execute(InputInterface $input, OutputInterface $output): int
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture\DefaultValue;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Output\OutputInterface;
+
+#[AsCommand(
+    name: 'app:hello',
+)]
+class ImplicitNoValueBoolOption
+{
+    public function __invoke(
+        #[\Symfony\Component\Console\Attribute\Option(name: 'third', mode: InputOption::VALUE_NONE)]
+        bool $third = false
+    ): int
+    {
+    }
+}
+
+?>

rules/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector.php

@@ -156,7 +156,6 @@ public function refactor(Node $node): ?Class_
         if ($configureClassMethod instanceof ClassMethod) {
             // 3. create arguments and options parameters
             $commandArguments = $this->commandArgumentsResolver->resolve($configureClassMethod);
-
             $commandOptions = $this->commandOptionsResolver->resolve($configureClassMethod);
 
             // 4. remove configure() method
@@ -173,17 +172,7 @@ public function refactor(Node $node): ?Class_
         // 6. remove parent class
         $node->extends = null;
 
-        foreach ($executeClassMethod->attrGroups as $attrGroupKey => $attrGroup) {
-            foreach ($attrGroup->attrs as $attributeKey => $attr) {
-                if ($this->isName($attr->name, 'Override')) {
-                    unset($attrGroup->attrs[$attributeKey]);
-                }
-            }
-
-            if ($attrGroup->attrs === []) {
-                unset($executeClassMethod->attrGroups[$attrGroupKey]);
-            }
-        }
+        $this->removeOverrideAttributeAsDifferentMethod($executeClassMethod);
 
         if ($configureClassMethod instanceof ClassMethod) {
             // 7. replace input->getArgument() and input->getOption() calls with direct variable access
@@ -266,4 +255,20 @@ private function isFluentArgumentOptionChain(MethodCall $methodCall): bool
         // the left-most var must be $this
         return $current instanceof Variable && $this->isName($current, 'this');
     }
+
+    private function removeOverrideAttributeAsDifferentMethod(ClassMethod $executeClassMethod): void
+    {
+        foreach ($executeClassMethod->attrGroups as $attrGroupKey => $attrGroup) {
+            foreach ($attrGroup->attrs as $attributeKey => $attr) {
+                if ($this->isName($attr->name, 'Override')) {
+                    unset($attrGroup->attrs[$attributeKey]);
+                }
+            }
+
+            // is attribute empty? remove whole group
+            if ($attrGroup->attrs === []) {
+                unset($executeClassMethod->attrGroups[$attrGroupKey]);
+            }
+        }
+    }
 }