tv skip param converter (#876)

* add fixture

* skip param converter param types

Author: TomasVotruba

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Fixture/skip_param_converter.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Source\SomeConvertedEntity;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class SkipParamConverter extends AbstractController
+{
+    #[ParamConverter('entity', class: SomeConvertedEntity::class)]
+    #[Route('/some-action', name: 'some_action')]
+    public function someAction(SomeConvertedEntity $entity)
+    {
+    }
+}

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Source/SomeConvertedEntity.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Source;
+
+final class SomeConvertedEntity
+{
+}

rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php

@@ -12,11 +12,14 @@
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
+use Rector\Doctrine\NodeAnalyzer\AttributeFinder;
 use Rector\NodeManipulator\ClassDependencyManipulator;
+use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\PostRector\ValueObject\PropertyMetadata;
 use Rector\Rector\AbstractRector;
 use Rector\StaticTypeMapper\StaticTypeMapper;
 use Rector\Symfony\Bridge\NodeAnalyzer\ControllerMethodAnalyzer;
+use Rector\Symfony\Enum\SensioAttribute;
 use Rector\Symfony\Enum\SymfonyClass;
 use Rector\Symfony\TypeAnalyzer\ControllerAnalyzer;
 use Rector\ValueObject\MethodName;
@@ -33,6 +36,8 @@ public function __construct(
         private readonly ControllerMethodAnalyzer $controllerMethodAnalyzer,
         private readonly ClassDependencyManipulator $classDependencyManipulator,
         private readonly StaticTypeMapper $staticTypeMapper,
+        private readonly AttributeFinder $attributeFinder,
+        private readonly ValueResolver $valueResolver,
     ) {
     }
 
@@ -108,15 +113,23 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            $entityClasses = $this->resolveParamConverterEntityClasses($classMethod);
+
             foreach ($classMethod->getParams() as $key => $param) {
                 // skip scalar and empty values, as not services
                 if ($param->type === null || $param->type instanceof Identifier) {
                     continue;
                 }
 
                 // request is allowed
-                if ($param->type instanceof Name && $this->isName($param->type, SymfonyClass::REQUEST)) {
-                    continue;
+                if ($param->type instanceof Name) {
+                    if ($this->isName($param->type, SymfonyClass::REQUEST)) {
+                        continue;
+                    }
+
+                    if ($this->isNames($param->type, $entityClasses)) {
+                        continue;
+                    }
                 }
 
                 // @todo allow parameter converter
@@ -188,4 +201,31 @@ private function shouldSkipClassMethod(ClassMethod $classMethod): bool
 
         return ! $this->controllerMethodAnalyzer->isAction($classMethod);
     }
+
+    /**
+     * @return string[]
+     */
+    private function resolveParamConverterEntityClasses(ClassMethod $classMethod): array
+    {
+        $entityClasses = [];
+
+        $paramConverterAttributes = $this->attributeFinder->findManyByClass(
+            $classMethod,
+            SensioAttribute::PARAM_CONVERTER
+        );
+        foreach ($paramConverterAttributes as $paramConverterAttribute) {
+            foreach ($paramConverterAttribute->args as $arg) {
+                if ($arg->name instanceof Identifier && $this->isName($arg->name, 'class')) {
+                    $entityClass = $this->valueResolver->getValue($arg->value);
+                    if (! is_string($entityClass)) {
+                        continue;
+                    }
+
+                    $entityClasses[] = $entityClass;
+                }
+            }
+        }
+
+        return $entityClasses;
+    }
 }

stubs/Symfony/Bundle/FrameworkExtraBundle/Configuration/ParamConverter.php

@@ -4,4 +4,15 @@
 
 class ParamConverter
 {
+    /**
+     * @param array|string $data
+     */
+    public function __construct(
+        $data = [],
+        string $class = null,
+        array $options = [],
+        bool $isOptional = false,
+        string $converter = null
+    ) {
+    }
 }