[symfony 3.4] split of per package configs

Author: TomasVotruba

config/sets/symfony/symfony3/symfony34.php

@@ -3,27 +3,10 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Removing\Rector\ClassMethod\ArgumentRemoverRector;
-use Rector\Removing\ValueObject\ArgumentRemover;
-use Rector\Symfony\Symfony34\Rector\ClassMethod\MergeMethodAnnotationToRouteAnnotationRector;
-use Rector\Symfony\Symfony34\Rector\ClassMethod\RemoveServiceFromSensioRouteRector;
-use Rector\Symfony\Symfony34\Rector\ClassMethod\ReplaceSensioRouteAnnotationWithSymfonyRector;
-use Rector\Symfony\Symfony34\Rector\Closure\ContainerGetNameToTypeInTestsRector;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->ruleWithConfiguration(ArgumentRemoverRector::class, [
-        new ArgumentRemover(
-            'Symfony\Component\Yaml\Yaml',
-            'parse',
-            2,
-            ['Symfony\Component\Yaml\Yaml::PARSE_KEYS_AS_STRINGS']
-        ),
-    ]);
+    $rectorConfig->import(__DIR__ . '/symfony34/symfony34-yaml.php');
+    $rectorConfig->import(__DIR__ . '/symfony34/symfony34-dependency-injection.php');
+    $rectorConfig->import(__DIR__ . '/symfony34/symfony34-sensio-framework-extra-bundle.php');
 
-    $rectorConfig->rules([
-        MergeMethodAnnotationToRouteAnnotationRector::class,
-        RemoveServiceFromSensioRouteRector::class,
-        ReplaceSensioRouteAnnotationWithSymfonyRector::class,
-        ContainerGetNameToTypeInTestsRector::class,
-    ]);
 };

config/sets/symfony/symfony3/symfony34/symfony34-dependency-injection.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Symfony\Symfony34\Rector\Closure\ContainerGetNameToTypeInTestsRector;
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([ContainerGetNameToTypeInTestsRector::class]);
+};

config/sets/symfony/symfony3/symfony34/symfony34-sensio-framework-extra-bundle.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Symfony34\Rector\ClassMethod\MergeMethodAnnotationToRouteAnnotationRector;
+use Rector\Symfony\Symfony34\Rector\ClassMethod\RemoveServiceFromSensioRouteRector;
+use Rector\Symfony\Symfony34\Rector\ClassMethod\ReplaceSensioRouteAnnotationWithSymfonyRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([
+        MergeMethodAnnotationToRouteAnnotationRector::class,
+        RemoveServiceFromSensioRouteRector::class,
+        ReplaceSensioRouteAnnotationWithSymfonyRector::class,
+    ]);
+};

config/sets/symfony/symfony3/symfony34/symfony34-yaml.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Removing\Rector\ClassMethod\ArgumentRemoverRector;
+use Rector\Removing\ValueObject\ArgumentRemover;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->ruleWithConfiguration(ArgumentRemoverRector::class, [
+        new ArgumentRemover(
+            'Symfony\Component\Yaml\Yaml',
+            'parse',
+            2,
+            ['Symfony\Component\Yaml\Yaml::PARSE_KEYS_AS_STRINGS']
+        ),
+    ]);
+};

rules/Symfony34/Rector/Closure/ContainerGetNameToTypeInTestsRector.php

@@ -30,9 +30,11 @@ public function __construct(
 
     public function getRuleDefinition(): RuleDefinition
     {
-        return new RuleDefinition('Change $container->get("some_name") to bare type, useful since Symfony 3.4', [
-            new CodeSample(
-                <<<'CODE_SAMPLE'
+        return new RuleDefinition(
+            'Change $container->get("some_name") in tests to bare type, useful since Symfony 3.4',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
 use PHPUnit\Framework\TestCase;
 
 final class SomeTest extends TestCase
@@ -45,8 +47,8 @@ public function run()
 }
 CODE_SAMPLE
 
-                ,
-                <<<'CODE_SAMPLE'
+                    ,
+                    <<<'CODE_SAMPLE'
 use PHPUnit\Framework\TestCase;
 
 final class SomeTest extends TestCase
@@ -58,8 +60,10 @@ public function run()
     }
 }
 CODE_SAMPLE
-            ),
-        ]);
+                ),
+
+            ]
+        );
     }
 
     /**