[Symfony73] Handle with set allowExtraFields named argument on ConstraintOptionsToNamedArgumentsRector (#924)

* [Symfony73] Handle with set allowExtraFields named argument on ConstraintOptionsToNamedArgumentsRector

* add fixture

Author: samsonasik

rules-tests/Symfony73/Rector/Class_/ConstraintOptionsToNamedArgumentsRector/Fixture/with_allow_extra_fields_false.php.inc

@@ -0,0 +1,41 @@
+<?php
+
+namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\ConstraintOptionsToNamedArgumentsRector\Fixture;
+
+use Symfony\Component\Validator\Constraints as Assert;
+
+final class WithAllowExtraFieldsFalse
+{
+    public function run(bool $param)
+    {
+        $constraints = new Assert\Collection([
+            'example1' => [new Assert\NotBlank(), new Assert\Type('string')],
+            'example2' => [new Assert\Type('string')],
+            'example3' => [new Assert\NotBlank(), new Assert\Type('string')],
+            'example4' => [new Assert\NotBlank(), new Assert\Type('string')],
+        ], allowExtraFields: false);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\ConstraintOptionsToNamedArgumentsRector\Fixture;
+
+use Symfony\Component\Validator\Constraints as Assert;
+
+final class WithAllowExtraFieldsFalse
+{
+    public function run(bool $param)
+    {
+        $constraints = new Assert\Collection(fields: [
+            'example1' => [new Assert\NotBlank(), new Assert\Type('string')],
+            'example2' => [new Assert\Type('string')],
+            'example3' => [new Assert\NotBlank(), new Assert\Type('string')],
+            'example4' => [new Assert\NotBlank(), new Assert\Type('string')],
+        ]);
+    }
+}
+
+?>

rules/Symfony73/Rector/Class_/ConstraintOptionsToNamedArgumentsRector.php

@@ -96,15 +96,30 @@ public function refactor(Node $node): ?Node
         }
 
         $args = $node->getArgs();
-        if ($className === SymfonyClass::SYMFONY_VALIDATOR_CONSTRAINTS_COLLECTION
-            && count($args) === 1
-            && $args[0]->value instanceof Array_) {
-
+        if ($className === SymfonyClass::SYMFONY_VALIDATOR_CONSTRAINTS_COLLECTION && $args[0]->value instanceof Array_) {
             if ($args[0]->name instanceof Identifier) {
                 return null;
             }
 
             $args[0]->name = new Identifier('fields');
+
+            foreach ($args as $key => $arg) {
+                if (! $arg->name instanceof Identifier) {
+                    continue;
+                }
+
+                if ($arg->name->toString() !== 'allowExtraFields') {
+                    continue;
+                }
+
+                if (! $this->valueResolver->isFalse($arg->value)) {
+                    continue;
+                }
+
+                unset($args[$key]);
+            }
+
+            $node->args = array_values($args);
             return $node;
         }