add ampersand support (#716)

Author: TomasVotruba

rules-tests/CodeQuality/Rector/Class_/SplitAndSecurityAttributeToIsGrantedRector/Fixture/with_ampersand_attributes.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\SplitAndSecurityAttributeToIsGrantedRector\Fixture;
+
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
+
+#[Security("is_granted('ROLE_USER') && is_granted('ROLE_ADMIN')")]
+final class WithAmpersandAttributes
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\SplitAndSecurityAttributeToIsGrantedRector\Fixture;
+
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
+
+#[\Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted('ROLE_USER')]
+#[\Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted('ROLE_ADMIN')]
+final class WithAmpersandAttributes
+{
+}
+
+?>

rules/CodeQuality/Rector/Class_/SplitAndSecurityAttributeToIsGrantedRector.php

@@ -4,12 +4,12 @@
 
 namespace Rector\Symfony\CodeQuality\Rector\Class_;
 
-use PhpParser\Node\Name\FullyQualified;
 use Nette\Utils\Strings;
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Attribute;
 use PhpParser\Node\AttributeGroup;
+use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -82,11 +82,16 @@ public function refactor(Node $node): ?Node
                 }
 
                 // we look for "and"s
-                if (! str_contains($content, ' and')) {
+                if (! str_contains($content, ' and ') && ! str_contains($content, ' && ')) {
                     continue;
                 }
 
-                $andItems = explode(' and ', $content);
+                // split by && and "and"
+                if (str_contains($content, ' && ')) {
+                    $andItems = explode(' && ', $content);
+                } else {
+                    $andItems = explode(' and ', $content);
+                }
 
                 $accessRights = [];
 
@@ -106,9 +111,7 @@ public function refactor(Node $node): ?Node
 
                 foreach ($accessRights as $accessRight) {
                     $attributeGroup = new AttributeGroup([
-                        new Attribute(new FullyQualified(IsGranted::class), [
-                            new Arg(new String_($accessRight)),
-                        ]),
+                        new Attribute(new FullyQualified(IsGranted::class), [new Arg(new String_($accessRight))]),
                     ]);
 
                     $node->attrGroups[] = $attributeGroup;