add type declaration based on dfeault value type

Author: TomasVotruba

rules-tests/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture/DefaultValue/argument_with_default_value.php.inc

@@ -47,7 +47,7 @@ class ArgumentWithDefaultValue
         #[\Symfony\Component\Console\Attribute\Argument(name: 'second')]
         string $second = 'required value',
         #[\Symfony\Component\Console\Attribute\Option(name: 'third')]
-        $third = 'third value'
+        string $third = 'third value'
     ): int
     {
     }

rules-tests/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture/DefaultValue/match_scalar_type.php.inc

@@ -51,9 +51,9 @@ class MatchScalarType
         #[\Symfony\Component\Console\Attribute\Argument(name: 'second')]
         float $second = 200.5,
         #[\Symfony\Component\Console\Attribute\Option(name: 'third')]
-        ?int $third = 200,
+        int $third = 200,
         #[\Symfony\Component\Console\Attribute\Option(name: 'fourth')]
-        ?float $fourth = 400.5
+        float $fourth = 400.5
     ): int
     {
     }

rules/Symfony73/NodeAnalyzer/CommandArgumentsResolver.php

@@ -4,10 +4,10 @@
 
 namespace Rector\Symfony\Symfony73\NodeAnalyzer;
 
-use PHPStan\Type\Type;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Stmt\ClassMethod;
+use PHPStan\Type\Type;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Symfony\Symfony73\NodeFinder\MethodCallFinder;

rules/Symfony73/NodeAnalyzer/CommandOptionsResolver.php

@@ -4,9 +4,9 @@
 
 namespace Rector\Symfony\Symfony73\NodeAnalyzer;
 
-use PHPStan\Type\Type;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Stmt\ClassMethod;
+use PHPStan\Type\Type;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Symfony\Symfony73\NodeFinder\MethodCallFinder;

rules/Symfony73/NodeFactory/CommandInvokeParamsFactory.php

@@ -13,7 +13,10 @@
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\NullableType;
 use PhpParser\Node\Param;
+use PHPStan\Type\Type;
 use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
+use Rector\StaticTypeMapper\StaticTypeMapper;
 use Rector\Symfony\Enum\SymfonyAttribute;
 use Rector\Symfony\Symfony73\ValueObject\CommandArgument;
 use Rector\Symfony\Symfony73\ValueObject\CommandOption;
@@ -22,6 +25,7 @@
 {
     public function __construct(
         private ValueResolver $valueResolver,
+        private StaticTypeMapper $staticTypeMapper
     ) {
     }
 
@@ -50,11 +54,7 @@ private function createArgumentParams(array $commandArguments): array
             $variableName = $this->createCamelCase($commandArgument->getNameValue());
             $argumentParam = new Param(new Variable($variableName));
 
-            if ($commandArgument->isArray()) {
-                $argumentParam->type = new Identifier('array');
-            } else {
-                $argumentParam->type = new Identifier('string');
-            }
+            $this->decorateArgumentParamType($argumentParam, $commandArgument);
 
             if ($commandArgument->getDefault() instanceof Expr) {
                 $argumentParam->default = $commandArgument->getDefault();
@@ -100,6 +100,8 @@ private function createOptionParams(array $commandOptions): array
                 $optionParam->default = $commandOption->getDefault();
             }
 
+            $this->decorateParamTypeByDefault($optionParam, $commandOption);
+
             $optionArgs = [new Arg(value: $commandOption->getName(), name: new Identifier('name'))];
 
             if ($this->isNonEmptyExpr($commandOption->getShortcut())) {
@@ -157,4 +159,36 @@ private function isNonEmptyExpr(?Expr $expr): bool
 
         return ! $this->valueResolver->isValue($expr, '');
     }
+
+    private function decorateArgumentParamType(Param $argumentParam, CommandArgument $commandArgument): void
+    {
+        if ($commandArgument->isArray()) {
+            $argumentParam->type = new Identifier('array');
+            return;
+        }
+
+        $this->decorateParamTypeByDefault($argumentParam, $commandArgument);
+    }
+
+    private function decorateParamTypeByDefault(
+        Param $argumentParam,
+        CommandArgument|CommandOption $commandArgumentOrOption
+    ): void {
+        $defaultType = $commandArgumentOrOption->getDefaultType();
+        if ($defaultType instanceof Type) {
+            $paramType = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($defaultType, TypeKind::PARAM);
+
+            if ($paramType instanceof \PhpParser\Node) {
+                $argumentParam->type = $paramType;
+                return;
+            }
+        }
+
+        // fallback
+        if ($commandArgumentOrOption instanceof CommandOption) {
+            return;
+        }
+
+        $argumentParam->type = new Identifier('string');
+    }
 }

rules/Symfony73/ValueObject/CommandArgument.php

@@ -4,8 +4,8 @@
 
 namespace Rector\Symfony\Symfony73\ValueObject;
 
-use PHPStan\Type\Type;
 use PhpParser\Node\Expr;
+use PHPStan\Type\Type;
 
 final readonly class CommandArgument
 {

rules/Symfony73/ValueObject/CommandOption.php

@@ -4,8 +4,8 @@
 
 namespace Rector\Symfony\Symfony73\ValueObject;
 
-use PHPStan\Type\Type;
 use PhpParser\Node\Expr;
+use PHPStan\Type\Type;
 
 final readonly class CommandOption
 {