[CodeQuality] Skip used by static closure use on ControllerMethodInjectionToConstructorRector (#928)

Author: samsonasik

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Fixture/skip_used_by_static_closure_use.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class SkipUsedByStaticClosureUse extends AbstractController
+{
+	public function example(Foo $foo): Response
+	{
+		dump($foo);
+
+		$problematic = static function() use ($foo): void {
+			dump($foo);
+		};
+
+		$problematic();
+	}
+}

rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\NodeVisitor;
 use PHPStan\Type\ObjectType;
 use Rector\NodeManipulator\ClassDependencyManipulator;
 use Rector\NodeTypeResolver\Node\AttributeKey;
@@ -208,6 +209,10 @@ public function refactor(Node $node): ?Node
                     continue;
                 }
 
+                if ($this->isUsedInStaticClosureUse($classMethod, $this->getName($param->var))) {
+                    continue;
+                }
+
                 unset($classMethod->params[$key]);
                 $propertyMetadatas[] = new PropertyMetadata($this->getName($param->var), $paramType);
             }
@@ -279,6 +284,35 @@ private function hasConflictedParamName(
         return false;
     }
 
+    private function isUsedInStaticClosureUse(ClassMethod $classMethod, string $paramName): bool
+    {
+        if ($classMethod->stmts === null) {
+            return false;
+        }
+
+        $found = false;
+        $this->traverseNodesWithCallable($classMethod->stmts, function (Node $node) use ($paramName, &$found): ?int {
+            if (! $node instanceof Closure) {
+                return null;
+            }
+
+            if (! $node->static) {
+                return null;
+            }
+
+            foreach ($node->uses as $closureUse) {
+                if ($this->isName($closureUse->var, $paramName)) {
+                    $found = true;
+                    return NodeVisitor::STOP_TRAVERSAL;
+                }
+            }
+
+            return null;
+        });
+
+        return $found;
+    }
+
     /**
      * @param string[] $paramNamesToReplace
      */