[symfony 4.0] split of particular configs, improve SetListProvider (#729)

Author: TomasVotruba

config/sets/symfony/symfony4/symfony40.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/symfony40/symfony40-validator.php');
+    $rectorConfig->import(__DIR__ . '/symfony40/symfony40-dependency-injection.php');
+    $rectorConfig->import(__DIR__ . '/symfony40/symfony40-process.php');
+    $rectorConfig->import(__DIR__ . '/symfony40/symfony40-forms.php');
+    $rectorConfig->import(__DIR__ . '/symfony40/symfony40-var-dumper.php');
+};

config/sets/symfony/symfony4/symfony40/symfony40-dependency-injection.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Symfony40\Rector\MethodCall\ContainerBuilderCompileEnvArgumentRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([ContainerBuilderCompileEnvArgumentRector::class]);
+};

config/sets/symfony/symfony4/symfony40/symfony40-forms.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Symfony40\Rector\MethodCall\FormIsValidRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([FormIsValidRector::class]);
+};

config/sets/symfony/symfony4/symfony40/symfony40-process.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Renaming\Rector\Name\RenameClassRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->ruleWithConfiguration(RenameClassRector::class, [
+        'Symfony\Component\Process\ProcessBuilder' => 'Symfony\Component\Process\Process',
+    ]);
+};

config/sets/symfony/symfony4/symfony40/symfony40-validator.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Renaming\Rector\Name\RenameClassRector;
+use Rector\Symfony\Symfony40\Rector\ConstFetch\ConstraintUrlOptionRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([ConstraintUrlOptionRector::class]);
+
+    $rectorConfig->ruleWithConfiguration(RenameClassRector::class, [
+        'Symfony\Component\Validator\Tests\Constraints\AbstractConstraintValidatorTest' => 'Symfony\Component\Validator\Test\ConstraintValidatorTestCase',
+    ]);
+};

config/sets/symfony/symfony4/symfony40/symfony40-var-dumper.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Symfony40\Rector\MethodCall\VarDumperTestTraitMethodArgsRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([VarDumperTestTraitMethodArgsRector::class]);
+};

config/sets/symfony/symfony40.php

@@ -143,32 +143,69 @@ public function provide(): array
                 __DIR__ . '/../../../config/sets/symfony/symfony3/symfony31/symfony31-yaml.php'
             ),
 
-            // @todo split rest
-
             new ComposerTriggeredSet(
                 SetGroup::SYMFONY,
-                'symfony/*',
+                'symfony/symfony',
                 '3.2',
                 __DIR__ . '/../../../config/sets/symfony/symfony3/symfony32.php'
             ),
             new ComposerTriggeredSet(
                 SetGroup::SYMFONY,
-                'symfony/*',
+                'symfony/symfony',
                 '3.3',
                 __DIR__ . '/../../../config/sets/symfony/symfony3/symfony33.php'
             ),
             new ComposerTriggeredSet(
                 SetGroup::SYMFONY,
-                'symfony/*',
+                'symfony/symfony',
                 '3.4',
                 __DIR__ . '/../../../config/sets/symfony/symfony3/symfony34.php'
             ),
+
             new ComposerTriggeredSet(
                 SetGroup::SYMFONY,
-                'symfony/*',
+                'symfony/symfony',
+                '4.0',
+                __DIR__ . '/../../../config/sets/symfony/symfony4/symfony40.php'
+            ),
+
+            new ComposerTriggeredSet(
+                SetGroup::SYMFONY,
+                'symfony/dependency-injection',
+                '4.0',
+                __DIR__ . '/../../../config/sets/symfony/symfony4/symfony40/symfony40-dependency-injection.php'
+            ),
+
+            new ComposerTriggeredSet(
+                SetGroup::SYMFONY,
+                'symfony/process',
                 '4.0',
-                __DIR__ . '/../../../config/sets/symfony/symfony40.php'
+                __DIR__ . '/../../../config/sets/symfony/symfony4/symfony40/symfony40-process.php'
             ),
+
+            new ComposerTriggeredSet(
+                SetGroup::SYMFONY,
+                'symfony/validator',
+                '4.0',
+                __DIR__ . '/../../../config/sets/symfony/symfony4/symfony40/symfony40-validator.php'
+            ),
+
+            new ComposerTriggeredSet(
+                SetGroup::SYMFONY,
+                'symfony/var-dumper',
+                '4.0',
+                __DIR__ . '/../../../config/sets/symfony/symfony4/symfony40/symfony40-var-dumper.php'
+            ),
+
+            new ComposerTriggeredSet(
+                SetGroup::SYMFONY,
+                'symfony/forms',
+                '4.0',
+                __DIR__ . '/../../../config/sets/symfony/symfony4/symfony40/symfony40-forms.php'
+            ),
+
+            // @todo split rest
+
             new ComposerTriggeredSet(
                 SetGroup::SYMFONY,
                 'symfony/*',

src/Set/SetProvider/SymfonySetProvider.php

@@ -64,7 +64,7 @@ final class SymfonySetList
     /**
      * @var string
      */
-    final public const SYMFONY_40 = __DIR__ . '/../../config/sets/symfony/symfony40.php';
+    final public const SYMFONY_40 = __DIR__ . '/../../config/sets/symfony/symfony4/symfony40.php';
 
     /**
      * @var string