upgrade syntax to PHP 8.3

Author: TomasVotruba

phpstan.neon

@@ -67,9 +67,6 @@ parameters:
 
         - '#Parameter 1 should use "PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionMethod" type as the only type passed to this method#'
 
-        # local use php 8.3
-        - identifier: typeCoverage.constantTypeCoverage
-
         # in tests
         -
             message: '#Fetching deprecated class constant SYMFONY_(.*?) of class Rector\\Symfony\\Set\\SymfonySetList#'

rector.php

@@ -37,14 +37,14 @@
         // marked as skipped
         ReturnNeverTypeRector::class => ['*/tests/*'],
     ])
-    // @todo cleanup rest and move to enum classes ass single place for class names
     ->withConfiguredRule(StringClassNameToClassConstantRector::class, ['Symfony\*', 'Twig_*', 'Twig*'])
     ->withPhpSets()
     ->withPreparedSets(
         deadCode: true,
         codeQuality: true,
         codingStyle: true,
         typeDeclarations: true,
+        typeDeclarationDocblocks: true,
         privatization: true,
         naming: true,
         rectorPreset: true,

rules/CodeQuality/Enum/ResponseClass.php

@@ -6,28 +6,13 @@
 
 final class ResponseClass
 {
-    /**
-     * @var string
-     */
-    public const REDIRECT = 'Symfony\Component\HttpFoundation\RedirectResponse';
+    public const string REDIRECT = 'Symfony\Component\HttpFoundation\RedirectResponse';
 
-    /**
-     * @var string
-     */
-    public const BINARY_FILE = 'Symfony\Component\HttpFoundation\BinaryFileResponse';
+    public const string BINARY_FILE = 'Symfony\Component\HttpFoundation\BinaryFileResponse';
 
-    /**
-     * @var string
-     */
-    public const JSON = 'Symfony\Component\HttpFoundation\JsonResponse';
+    public const string JSON = 'Symfony\Component\HttpFoundation\JsonResponse';
 
-    /**
-     * @var string
-     */
-    public const STREAMED = 'Symfony\Component\HttpFoundation\StreamedResponse';
+    public const string STREAMED = 'Symfony\Component\HttpFoundation\StreamedResponse';
 
-    /**
-     * @var string
-     */
-    public const BASIC = 'Symfony\Component\HttpFoundation\Response';
+    public const string BASIC = 'Symfony\Component\HttpFoundation\Response';
 }

rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php

@@ -37,7 +37,7 @@ final class ControllerMethodInjectionToConstructorRector extends AbstractRector
     /**
      * @var string[]
      */
-    private const COMMON_ENTITY_CONTAINS_SUBNAMESPACES = ["\\Entity", "\\Document", "\\Model"];
+    private const array COMMON_ENTITY_CONTAINS_SUBNAMESPACES = ["\\Entity", "\\Document", "\\Model"];
 
     public function __construct(
         private readonly ControllerAnalyzer $controllerAnalyzer,

rules/CodeQuality/Rector/Class_/EventListenerToEventSubscriberRector.php

@@ -28,10 +28,9 @@
 final class EventListenerToEventSubscriberRector extends AbstractRector
 {
     /**
-     * @var string
      * @changelog https://regex101.com/r/qiHZ4T/1
      */
-    private const LISTENER_MATCH_REGEX = '#^(.*?)(Listener)?$#';
+    private const string LISTENER_MATCH_REGEX = '#^(.*?)(Listener)?$#';
 
     /**
      * @var EventNameToClassAndConstant[]

rules/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector.php

@@ -33,16 +33,13 @@ final class InlineClassRoutePrefixRector extends AbstractRector
     /**
      * @var string[]
      */
-    private const FOS_REST_ANNOTATIONS = [
+    private const array FOS_REST_ANNOTATIONS = [
         FosAnnotation::REST_POST,
         FosAnnotation::REST_GET,
         FosAnnotation::REST_ROUTE,
     ];
 
-    /**
-     * @var string
-     */
-    private const PATH = 'path';
+    private const string PATH = 'path';
 
     public function __construct(
         private readonly PhpDocInfoFactory $phpDocInfoFactory,

rules/Configs/NodeVisitor/CollectServiceArgumentsNodeVisitor.php

@@ -22,15 +22,9 @@
 
 final class CollectServiceArgumentsNodeVisitor extends NodeVisitorAbstract
 {
-    /**
-     * @var string
-     */
-    private const ENVS = 'envs';
+    private const string ENVS = 'envs';
 
-    /**
-     * @var string
-     */
-    private const PARAMETERS = 'parameters';
+    private const string PARAMETERS = 'parameters';
 
     /**
      * @var array<string, array<self::ENVS|self::PARAMETERS, array<string|Expr>>>

rules/Configs/Rector/Class_/AutowireAttributeRector.php

@@ -35,10 +35,7 @@
  */
 final class AutowireAttributeRector extends AbstractRector implements ConfigurableRectorInterface
 {
-    /**
-     * @var string
-     */
-    public const CONFIGS_DIRECTORY = 'configs_directory';
+    public const string CONFIGS_DIRECTORY = 'configs_directory';
 
     private ?string $configsDirectory = null;
 

rules/Configs/Rector/Closure/ServiceTagsToDefaultsAutoconfigureRector.php

@@ -23,7 +23,7 @@ final class ServiceTagsToDefaultsAutoconfigureRector extends AbstractRector
     /**
      * @var string[]
      */
-    private const AUTOCONFIGUREABLE_TAGS = [
+    private const array AUTOCONFIGUREABLE_TAGS = [
         // @todo fill
         'twig.extension',
         'console.command',

rules/DependencyInjection/Rector/Class_/GetBySymfonyStringToConstructorInjectionRector.php

@@ -27,7 +27,7 @@ final class GetBySymfonyStringToConstructorInjectionRector extends AbstractRecto
     /**
      * @var array<string, string>
      */
-    private const SYMFONY_NAME_TO_TYPE_MAP = [
+    private const array SYMFONY_NAME_TO_TYPE_MAP = [
         'validator' => SymfonyClass::VALIDATOR_INTERFACE,
         'event_dispatcher' => SymfonyClass::EVENT_DISPATCHER_INTERFACE,
         'logger' => SymfonyClass::LOGGER_INTERFACE,