add type support to option add array support

Author: TomasVotruba

rules-tests/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture/DefaultValue/option_with_array_type.php.inc

@@ -0,0 +1,52 @@
+<?php
+
+namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture\DefaultValue;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Output\OutputInterface;
+
+#[AsCommand(
+    name: 'app:hello',
+)]
+class OptionWithOptionalValue extends Command
+{
+    protected function configure(): void
+    {
+        $this->addOption('some-array', null, InputOption::VALUE_IS_ARRAY, '', ['third value']);
+        $this->addOption('no-default-array', null, InputOption::VALUE_IS_ARRAY);
+    }
+    protected function execute(InputInterface $input, OutputInterface $output): int
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture\DefaultValue;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Output\OutputInterface;
+
+#[AsCommand(
+    name: 'app:hello',
+)]
+class OptionWithOptionalValue
+{
+    public function __invoke(#[\Symfony\Component\Console\Attribute\Option(name: 'some-array', mode: InputOption::VALUE_IS_ARRAY)]
+    array $someArray = ['third value'], #[\Symfony\Component\Console\Attribute\Option(name: 'no-default-array', mode: InputOption::VALUE_IS_ARRAY)]
+    array $noDefaultArray): int
+    {
+    }
+}
+
+?>

rules/Symfony73/NodeAnalyzer/CommandOptionsResolver.php

@@ -5,6 +5,7 @@
 namespace Rector\Symfony\Symfony73\NodeAnalyzer;
 
 use PhpParser\Node\Arg;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Type\Type;
 use Rector\NodeTypeResolver\NodeTypeResolver;
@@ -42,6 +43,7 @@ public function resolve(ClassMethod $configureClassMethod): array
                 $addOptionArgs[2]->value ?? null,
                 $addOptionArgs[3]->value ?? null,
                 $addOptionArgs[4]->value ?? null,
+                $this->isArrayMode($addOptionArgs),
                 $this->resolveDefaultType($addOptionArgs)
             );
         }
@@ -61,4 +63,19 @@ private function resolveDefaultType(array $args): ?Type
 
         return $this->nodeTypeResolver->getType($defaultArg->value);
     }
+
+    /**
+     * @param Arg[] $args
+     */
+    private function isArrayMode(array $args): bool
+    {
+        $modeExpr = $args[2]->value ?? null;
+        if (! $modeExpr instanceof Expr) {
+            return false;
+        }
+
+        $modeValue = $this->valueResolver->getValue($modeExpr);
+        // binary check for InputOptions::VALUE_IS_ARRAY
+        return (bool) ($modeValue & 8);
+    }
 }

rules/Symfony73/NodeFactory/CommandInvokeParamsFactory.php

@@ -54,7 +54,7 @@ private function createArgumentParams(array $commandArguments): array
             $variableName = $this->createCamelCase($commandArgument->getNameValue());
             $argumentParam = new Param(new Variable($variableName));
 
-            $this->decorateArgumentParamType($argumentParam, $commandArgument);
+            $this->decorateParamType($argumentParam, $commandArgument);
 
             if ($commandArgument->getDefault() instanceof Expr) {
                 $argumentParam->default = $commandArgument->getDefault();
@@ -100,7 +100,7 @@ private function createOptionParams(array $commandOptions): array
                 $optionParam->default = $commandOption->getDefault();
             }
 
-            $this->decorateParamTypeByDefault($optionParam, $commandOption);
+            $this->decorateParamType($optionParam, $commandOption);
 
             $optionArgs = [new Arg(value: $commandOption->getName(), name: new Identifier('name'))];
 
@@ -160,20 +160,15 @@ private function isNonEmptyExpr(?Expr $expr): bool
         return ! $this->valueResolver->isValue($expr, '');
     }
 
-    private function decorateArgumentParamType(Param $argumentParam, CommandArgument $commandArgument): void
-    {
-        if ($commandArgument->isArray()) {
+    private function decorateParamType(
+        Param $argumentParam,
+        CommandArgument|CommandOption $commandArgumentOrOption
+    ): void {
+        if ($commandArgumentOrOption->isArray()) {
             $argumentParam->type = new Identifier('array');
             return;
         }
 
-        $this->decorateParamTypeByDefault($argumentParam, $commandArgument);
-    }
-
-    private function decorateParamTypeByDefault(
-        Param $argumentParam,
-        CommandArgument|CommandOption $commandArgumentOrOption
-    ): void {
         $defaultType = $commandArgumentOrOption->getDefaultType();
         if ($defaultType instanceof Type) {
             $paramType = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($defaultType, TypeKind::PARAM);

rules/Symfony73/ValueObject/CommandOption.php

@@ -16,6 +16,7 @@ public function __construct(
         private ?Expr $mode,
         private ?Expr $description,
         private ?Expr $default,
+        private bool $isArray,
         private ?Type $defaultType
     ) {
     }
@@ -54,4 +55,9 @@ public function getDefaultType(): ?Type
     {
         return $this->defaultType;
     }
+
+    public function isArray(): bool
+    {
+        return $this->isArray;
+    }
 }