Fix rule when method is __invoke (#884)

* Fix rule when method is __invoke

* Use method isUnsafeOverridden and fix TU

---------

Co-authored-by: Johan MARTIN <johan.martin@kosmos.fr>

Author: wilfi00

rules-tests/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector/Fixture/with_invoke_method.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\Routing\Annotation\Route;
+
+/**
+ * @Route(path="/city", name="some_org.")
+ */
+final class WithInvokeMethod extends Controller
+{
+    /**
+     * @Route("/street", name="some")
+     */
+    public function __invoke()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\InlineClassRoutePrefixRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class WithInvokeMethod extends Controller
+{
+    /**
+     * @Route("/city/street", name="some_org.some")
+     */
+    public function __invoke()
+    {
+    }
+}
+
+?>

rules/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector.php

@@ -15,6 +15,7 @@
 use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTagRemover;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
 use Rector\Doctrine\NodeAnalyzer\AttrinationFinder;
+use Rector\NodeAnalyzer\MagicClassMethodAnalyzer;
 use Rector\Rector\AbstractRector;
 use Rector\Symfony\Enum\FosAnnotation;
 use Rector\Symfony\Enum\SymfonyAnnotation;
@@ -47,7 +48,8 @@ public function __construct(
         private readonly PhpDocTagRemover $phpDocTagRemover,
         private readonly DocBlockUpdater $docBlockUpdater,
         private readonly ControllerAnalyzer $controllerAnalyzer,
-        private readonly AttrinationFinder $attrinationFinder
+        private readonly AttrinationFinder $attrinationFinder,
+        private readonly MagicClassMethodAnalyzer $magicClassMethodAnalyzer
     ) {
     }
 
@@ -134,7 +136,7 @@ public function refactor(Node $node): ?Class_
         $hasChanged = false;
 
         foreach ($node->getMethods() as $classMethod) {
-            if (! $classMethod->isPublic() || $classMethod->isMagic()) {
+            if ($this->shouldSkipMethod($classMethod)) {
                 continue;
             }
 
@@ -255,14 +257,21 @@ public function refactor(Node $node): ?Class_
         return $node;
     }
 
+    private function shouldSkipMethod(Node\Stmt\ClassMethod $classMethod): bool
+    {
+        return
+            !$classMethod->isPublic()
+            || $this->magicClassMethodAnalyzer->isUnsafeOverridden($classMethod);
+    }
+
     private function shouldSkipClass(Class_ $class): bool
     {
         if (! $this->controllerAnalyzer->isController($class)) {
             return true;
         }
 
         foreach ($class->getMethods() as $classMethod) {
-            if (! $classMethod->isPublic() || $classMethod->isMagic()) {
+            if ($this->shouldSkipMethod($classMethod)) {
                 continue;
             }