[code-quality] add filter_var() support to ParameterBagTypedGetMethodCallRector (#836)

* add filter var fixture

* add filter_var() support to ParameterBagTypedGetMethodCallRector

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/ParameterBagTypedGetMethodCallRector/Fixture/filter_var.php.inc

@@ -0,0 +1,34 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\MethodCall\ParameterBagTypedGetMethodCallRector\Fixture;
+
+use Symfony\Component\HttpFoundation\Request;
+
+final class GetOnBoolean
+{
+    public function run(Request $request)
+    {
+        $debug = filter_var(
+            $request->query->get('debug', false),
+            FILTER_VALIDATE_BOOLEAN
+        );
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\MethodCall\ParameterBagTypedGetMethodCallRector\Fixture;
+
+use Symfony\Component\HttpFoundation\Request;
+
+final class GetOnBoolean
+{
+    public function run(Request $request)
+    {
+        $debug = $request->query->getBoolean('debug');
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/ParameterBagTypedGetMethodCallRector/Fixture/skip_no_inner_type.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\MethodCall\ParameterBagTypedGetMethodCallRector\Fixture;
+
+use Symfony\Component\HttpFoundation\Request;
+
+final class SkipNoInnerType
+{
+    public function run(Request $request)
+    {
+        $debug = filter_var(
+            $request->query->get('debug', true),
+            FILTER_VALIDATE_BOOLEAN
+        );
+    }
+}

rules-tests/CodeQuality/Rector/MethodCall/ParameterBagTypedGetMethodCallRector/Fixture/skip_sole_expr_filter_var.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\MethodCall\ParameterBagTypedGetMethodCallRector\Fixture;
+
+use Symfony\Component\HttpFoundation\Request;
+
+final class SkipSoleExprFilterVar
+{
+    public function run(Request $request)
+    {
+        $debug = filter_var(
+            $request->query->get('debug', false),
+        );
+    }
+}

rules/CodeQuality/Rector/MethodCall/ParameterBagTypedGetMethodCallRector.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\Cast\Bool_;
+use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Identifier;
 use PHPStan\Type\ObjectType;
@@ -67,14 +68,18 @@ public function run(Request $request)
      */
     public function getNodeTypes(): array
     {
-        return [MethodCall::class, Bool_::class];
+        return [MethodCall::class, Bool_::class, FuncCall::class];
     }
 
     /**
-     * @param MethodCall|Bool_ $node
+     * @param MethodCall|Bool_|FuncCall $node
      */
     public function refactor(Node $node): ?Node
     {
+        if ($node instanceof FuncCall && $this->isName($node->name, 'filter_var')) {
+            return $this->refactorFilterVarFuncCall($node);
+        }
+
         if ($node instanceof Bool_) {
             if (! $node->expr instanceof MethodCall) {
                 return null;
@@ -126,4 +131,28 @@ private function refactorMethodCall(MethodCall $methodCall): ?MethodCall
 
         return null;
     }
+
+    private function refactorFilterVarFuncCall(FuncCall $funcCall): ?MethodCall
+    {
+        if ($funcCall->isFirstClassCallable()) {
+            return null;
+        }
+
+        // needs at least 2 args
+        if (count($funcCall->getArgs()) < 2) {
+            return null;
+        }
+
+        $flagArg = $funcCall->getArgs()[1];
+        if (! $this->valueResolver->isValue($flagArg->value, 'FILTER_VALIDATE_BOOLEAN')) {
+            return null;
+        }
+
+        $exprArg = $funcCall->getArgs()[0];
+        if (!$exprArg->value instanceof MethodCall) {
+            return null;
+        }
+
+        return $this->refactorMethodCall($exprArg->value);
+    }
 }